test: protect tests from bad random height #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirvalhalla
approved these changes
Oct 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 82.81% 82.87% +0.06%
==========================================
Files 173 173
Lines 8058 8058
==========================================
+ Hits 6673 6678 +5
+ Misses 1064 1060 -4
+ Partials 321 320 -1 |
|
@b00f please fix the deadlock and race condition |
amirvalhalla
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the random height is always greater than 1000.