Ensure lshw output is always listified #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
force-pushed
the
ensure-lshw-list-output
branch
2 times, most recently
from
af5f805 to
5454563
Compare
lshw changed the output of -xml between B.02.19 and B.02.20, in commit 2b1c730b493d647bbab4854713571458e82a81e7 (https://ezix.org/src/pkg/lshw/commit/2b1c730b493d647bbab4854713571458e82a81e7). This commit seems to try to fix the JSON output but in doing so sets `disable("output:list")` in main. This was feature/setting was being used by the code in hwNode::asXML. It seems that options are default enabled and thus we were getting the xml data listified. When the output:list was disabled in that commit we stopped getting listified xml. I have verified that we can enable the option by passing it in the cli args as `-enable output:list`. Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
ensure-lshw-list-output
branch
from
5454563 to
751d4e6
Compare
ofaurax
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lshw changed the output of -xml between B.02.19 and B.02.20, in commit 2b1c730b493d647bbab4854713571458e82a81e7 (https://ezix.org/src/pkg/lshw/commit/2b1c730b493d647bbab4854713571458e82a81e7). This commit seems to try to fix the JSON output but in doing so sets
disable("output:list")in main. This was feature/setting was being used by the code in hwNode::asXML.It seems that options are default enabled and thus we were getting the xml data listified. When the output:list was disabled in that commit we stopped getting listified xml. I have verified that we can enable the option by passing it in the cli args as
-enable output:list.