PHP: use SensitiveParameter annotation

packagist · Dec 9, 2024 · bdc90e9 · bdc90e9
1 parent 36fc43a
commit bdc90e9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -48,8 +48,12 @@ public function __construct(HttpPluginClientBuilder $httpClientBuilder = null, $
      * @param string $key
      * @param string $secret
      */
-    public function authenticate($key, $secret)
-    {
+    public function authenticate(
+        #[\SensitiveParameter]
+        $key,
+        #[\SensitiveParameter]
+        $secret
+    ) {
         $this->httpClientBuilder->removePlugin(RequestSignature::class);
         $this->httpClientBuilder->addPlugin(new RequestSignature($key, $secret));
     }

diff --git a/src/HttpClient/Plugin/RequestSignature.php b/src/HttpClient/Plugin/RequestSignature.php
@@ -25,8 +25,12 @@ class RequestSignature implements Plugin
      * @param string $key
      * @param string $secret
      */
-    public function __construct($key, $secret)
-    {
+    public function __construct(
+        #[\SensitiveParameter]
+        $key,
+        #[\SensitiveParameter]
+        $secret
+    ) {
         if (!$key || !$secret) {
             throw new \InvalidArgumentException('$key and $secret must be set');
         }

diff --git a/src/WebhookSignature.php b/src/WebhookSignature.php
@@ -14,8 +14,10 @@ class WebhookSignature
     /** @var string */
     private $secret;
 
-    public function __construct($secret)
-    {
+    public function __construct(
+        #[\SensitiveParameter]
+        $secret
+    ) {
         $this->secret = $secret;
     }