Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge qspec funcs #1804

Closed
wants to merge 2 commits into from
Closed

Merge qspec funcs #1804

wants to merge 2 commits into from

Conversation

oerc0122
Copy link
Collaborator

@oerc0122 oerc0122 commented Jan 8, 2025

Merge separate implementation of computing qw from original data.

This is a potentially incomplete process as there may be other qw calculators scattered throughout the code.

@oerc0122 oerc0122 added the Technical Debt code quality, unit tests, code duplicaton label Jan 8, 2025
@oerc0122 oerc0122 self-assigned this Jan 8, 2025
abuts
abuts previously approved these changes Jan 10, 2025
Copy link
Member

@abuts abuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like reasonable change. Should go ahead.

@abuts abuts force-pushed the merge-qspec-funcs branch from 2493e5f to f2ccc46 Compare February 3, 2025 11:15
@abuts abuts self-requested a review February 3, 2025 17:39
@abuts abuts dismissed their stale review February 3, 2025 17:40

Task itself is useful and necessary but the job is far from completeon

@abuts
Copy link
Member

abuts commented Feb 6, 2025

This will be part of fix-calc-qw-pix2 branch (Re #1152)

@abuts abuts closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt code quality, unit tests, code duplicaton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants