Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efficiency of multifit_funceval #1372

Open
abuts opened this issue Nov 5, 2023 · 0 comments
Open

efficiency of multifit_funceval #1372

abuts opened this issue Nov 5, 2023 · 0 comments
Labels
Low Priority Low Priority Tasks Optimisation Code optimisation required

Comments

@abuts
Copy link
Member

abuts commented Nov 5, 2023

the function multifit:@mf_class/private/multifit_funceval.m works with page_op through binary operations and funceval operations.
When these operations are applied to filebacked objects, each operation involves the scan of the whole backing-file. The scan and data IO is often the most expensive operation in evaluation.

It is relatively easy to write mutlifit_funceval-specific page_op, which would perform all filebacked operations in a single scan. This would substantially improve the speed of the operation. It is also possible to enable some specific optimization on pixel operations as e.g. background and foreground objects are often calculated on the same sqw object, so no internal pixel sorting is necessary.

@abuts abuts added the Optimisation Code optimisation required label Nov 5, 2023
@abuts abuts changed the title efficciency of multifit_funceval efficiency of multifit_funceval Nov 5, 2023
@oerc0122 oerc0122 added the Low Priority Low Priority Tasks label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Low Priority Tasks Optimisation Code optimisation required
Projects
None yet
Development

No branches or pull requests

2 participants