Fix Py_None increment bug #270

pace-neutrons · May 30, 2023 · ffb428f · ffb428f
1 parent 51cb4e7
commit ffb428f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -5,6 +5,8 @@
 
   - Allow ``color`` to be passed as an extra kwarg to ``plot_1d`` and
     ``plot_1d_to_axis``. Previously this caused a ``TypeError``.
+  - Fix bug where ``Py_None`` was not incremented before returning from
+    ``calculate_phonons()`` in the C-extension causing a deallocation crash
 
 `v1.2.0 <https://github.com/pace-neutrons/Euphonic/compare/v1.1.0...v1.2.0>`_
 ------

diff --git a/c/_euphonic.c b/c/_euphonic.c
@@ -300,7 +300,7 @@ static PyObject *calculate_phonons(PyObject *self, PyObject *args) {
         Py_DECREF(py_dipole_init_data);
     }
 
-    return Py_None;
+    Py_RETURN_NONE;
 }
 
 static PyMethodDef _euphonic_methods[] = {