Move imports with optional dependencies inside from_model functions

pace-neutrons · May 27, 2020 · 76a689a · 76a689a
1 parent c42cd7e
commit 76a689a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/euphonic/force_constants.py b/euphonic/force_constants.py
@@ -10,8 +10,6 @@
 from euphonic.crystal import Crystal
 from euphonic.qpoint_phonon_modes import QpointPhononModes
 from euphonic.util import is_gamma, get_all_origins, _check_constructor_inputs
-from euphonic.readers import castep
-from euphonic.readers import phonopy
 from euphonic.io import (_obj_to_json_file, _obj_from_json_file,
                          _obj_to_dict, _process_dict)
 
@@ -1266,6 +1264,7 @@ def from_castep(cls, filename):
         -------
         ForceConstants
         """
+        from euphonic.readers import castep
         data = castep._read_interpolation_data(filename)
         return cls.from_dict(data)
 
@@ -1303,6 +1302,7 @@ def from_phonopy(cls, path='.', summary_name='phonopy.yaml',
         -------
         ForceConstants
         """
+        from euphonic.readers import phonopy
         data = phonopy._read_interpolation_data(
             path=path, summary_name=summary_name, born_name=born_name,
             fc_name=fc_name, fc_format=fc_format)

diff --git a/euphonic/qpoint_phonon_modes.py b/euphonic/qpoint_phonon_modes.py
@@ -8,8 +8,6 @@
 from euphonic.structure_factor import StructureFactor
 from euphonic.util import (direction_changed, is_gamma,
                            _check_constructor_inputs)
-from euphonic.readers import castep
-from euphonic.readers import phonopy
 from euphonic.io import (_obj_to_json_file, _obj_from_json_file,
                          _obj_to_dict, _process_dict)
 
@@ -472,6 +470,7 @@ def from_castep(cls, filename):
         -------
         QpointPhononModes
         """
+        from euphonic.readers import castep
         data = castep._read_phonon_data(filename)
         return cls.from_dict(data)
 
@@ -503,6 +502,7 @@ def from_phonopy(cls, path='.', phonon_name='band.yaml',
         -------
         QpointPhononModes
         """
+        from euphonic.readers import phonopy
         data = phonopy._read_phonon_data(
             path=path, phonon_name=phonon_name, phonon_format=phonon_format,
             summary_name=summary_name)