Skip to content

Commit

Permalink
frameworks/av: Fix audio Android.bp files
Browse files Browse the repository at this point in the history
$ find . -name Android.bp | xargs ../../prebuilts/build-tools/linux-x86/bin/bpfmt -s -w

Note that bpfmt has a -s sort option.

Test: treehugger
Bug: 329877144
Change-Id: I7afcaa71d6ec1b71cec4a148d226c92660ec945c
  • Loading branch information
xt0032rus committed Mar 19, 2024
1 parent 37a30d9 commit a159e4b
Show file tree
Hide file tree
Showing 67 changed files with 443 additions and 438 deletions.
2 changes: 1 addition & 1 deletion media/audio/aconfig/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ cc_aconfig_library {
// TODO(b/316909431) native_bridge_supported: true,
apex_available: [
"//apex_available:platform",
"com.android.btservices",
"com.android.media",
"com.android.media.swcodec",
"com.android.btservices",
],
min_sdk_version: "29",
}
Expand Down
12 changes: 6 additions & 6 deletions media/audioaidlconversion/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ cc_library_headers {
cc_defaults {
name: "audio_aidl_conversion_common_default_cpp",
shared_libs: [
"framework-permission-aidl-cpp",
"libbinder",
"libshmemcompat",
"shared-file-region-aidl-cpp",
"framework-permission-aidl-cpp",
],
export_shared_lib_headers: [
"shared-file-region-aidl-cpp",
Expand Down Expand Up @@ -94,8 +94,8 @@ cc_defaults {
],
sanitize: {
misc_undefined: [
"unsigned-integer-overflow",
"signed-integer-overflow",
"unsigned-integer-overflow",
],
},
target: {
Expand Down Expand Up @@ -148,8 +148,8 @@ cc_library {
"latest_android_media_audio_common_types_ndk_shared",
],
shared_libs: [
"libbinder_ndk",
"libbase",
"libbinder_ndk",
],
static_libs: [
"libaudioaidlcommon",
Expand Down Expand Up @@ -182,8 +182,8 @@ cc_library {
],
shared_libs: [
"libaudio_aidl_conversion_common_ndk",
"libbinder_ndk",
"libbase",
"libbinder_ndk",
],
cflags: [
"-DBACKEND_NDK",
Expand Down Expand Up @@ -213,8 +213,8 @@ cc_library {
],
shared_libs: [
"libaudio_aidl_conversion_common_ndk",
"libbinder_ndk",
"libbase",
"libbinder_ndk",
],
cflags: [
"-DBACKEND_NDK",
Expand All @@ -238,8 +238,8 @@ cc_library {
"latest_android_media_audio_common_types_ndk_shared",
],
shared_libs: [
"libbinder_ndk",
"libbase",
"libbinder_ndk",
],
cflags: [
"-DBACKEND_CPP_NDK",
Expand Down
4 changes: 2 additions & 2 deletions media/audioaidlconversion/tests/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ cc_defaults {
],
sanitize: {
misc_undefined: [
"unsigned-integer-overflow",
"signed-integer-overflow",
"unsigned-integer-overflow",
],
},
}
Expand All @@ -26,8 +26,8 @@ cc_test {
name: "audio_aidl_ndk_conversion_tests",

defaults: [
"latest_android_media_audio_common_types_ndk_static",
"latest_android_hardware_audio_common_ndk_static",
"latest_android_media_audio_common_types_ndk_static",
"libaudio_aidl_conversion_tests_defaults",
],
srcs: ["audio_aidl_ndk_conversion_tests.cpp"],
Expand Down
4 changes: 2 additions & 2 deletions media/audioserver/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ cc_binary {
],

defaults: [
"latest_android_hardware_audio_core_sounddose_ndk_shared",
"latest_android_media_audio_common_types_cpp_shared",
"libaaudioservice_dependencies",
"libaudioflinger_dependencies",
"libaudiopolicyservice_dependencies",
"latest_android_media_audio_common_types_cpp_shared",
"latest_android_hardware_audio_core_sounddose_ndk_shared",
],

static_libs: [
Expand Down
38 changes: 19 additions & 19 deletions media/libaaudio/fuzzer/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -36,37 +36,37 @@ cc_fuzz {
"libaaudio_headers",
],
shared_libs: [
"libbinder",
"com.android.media.aaudio-aconfig-cc",
"libaudio_aidl_conversion_common_cpp",
"libaudioclient_aidl_conversion",
"libaudiomanager",
"libaudiopolicy",
"libaudioclient_aidl_conversion",
"libaudio_aidl_conversion_common_cpp",
"libbinder",
"libutils",
"com.android.media.aaudio-aconfig-cc",
],
static_libs: [
"liblog",
"libcutils",
"aaudio-aidl-cpp",
"audioclient-types-aidl-cpp",
"audioflinger-aidl-cpp",
"audiopolicy-aidl-cpp",
"audiopolicy-types-aidl-cpp",
"av-types-aidl-cpp",
"framework-permission-aidl-cpp",
"libaaudio",
"libjsoncpp",
"libaaudio_internal",
"libaudioclient",
"libaudioutils",
"libbase_ndk",
"libcgrouprc",
"libaudioutils",
"libaudioclient",
"aaudio-aidl-cpp",
"libcgrouprc_format",
"libcutils",
"libjsoncpp",
"liblog",
"libmedia_helper",
"libmediametrics",
"libprocessgroup",
"av-types-aidl-cpp",
"libaaudio_internal",
"libcgrouprc_format",
"audiopolicy-aidl-cpp",
"audioflinger-aidl-cpp",
"audiopolicy-types-aidl-cpp",
"audioclient-types-aidl-cpp",
"shared-file-region-aidl-cpp",
"framework-permission-aidl-cpp",
"mediametricsservice-aidl-cpp",
"shared-file-region-aidl-cpp",
],
fuzz_config: {
cc: [
Expand Down
90 changes: 46 additions & 44 deletions media/libaaudio/src/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ tidy_errors = [
"-bugprone-macro-parentheses", // found in SharedMemoryParcelable.h
"-bugprone-narrowing-conversions", // found in several interface from size_t to int32_t

"-google-readability-casting", // C++ casts not always necessary and may be verbose
"-google-readability-todo", // do not require TODO(info)
"-google-build-using-namespace", // Reenable and fix later.
"-google-global-names-in-headers", // found in several files
"-google-readability-casting", // C++ casts not always necessary and may be verbose
"-google-readability-todo", // do not require TODO(info)

"-misc-non-private-member-variables-in-classes", // found in aidl generated files

Expand Down Expand Up @@ -90,28 +90,30 @@ cc_library {
],

cflags: [
"-Wthread-safety",
"-Wno-unused-parameter",
"-Wall",
"-Werror",
// By default, all symbols are hidden.

// "-fvisibility=hidden",
// AAUDIO_API is used to explicitly export a function or a variable as a visible symbol.
"-Wno-unused-parameter",
"-Wthread-safety",

"-DAAUDIO_API=__attribute__((visibility(\"default\")))",
],

shared_libs: [
"framework-permission-aidl-cpp",
"libaaudio_internal",
"libaudioclient",
"libaudioutils",
"libbinder",
"libcutils",
"liblog",
"libmedia_helper",
"libmediametrics",
"libmediautils",
"liblog",
"libcutils",
"libutils",
"libbinder",
"framework-permission-aidl-cpp",
],

sanitize: {
Expand Down Expand Up @@ -161,77 +163,70 @@ cc_library {
],

shared_libs: [
"aaudio-aidl-cpp",
"audioclient-types-aidl-cpp",
"com.android.media.aaudio-aconfig-cc",
"framework-permission-aidl-cpp",
"libaudioclient",
"libaudioclient_aidl_conversion",
"libaudioutils",
"libbinder",
"libcutils",
"liblog",
"libmedia_helper",
"libmediametrics",
"libmediautils",
"liblog",
"libcutils",
"libutils",
"libbinder",
"framework-permission-aidl-cpp",
"aaudio-aidl-cpp",
"audioclient-types-aidl-cpp",
"libaudioclient_aidl_conversion",
"com.android.media.aaudio-aconfig-cc",
],

cflags: [
"-Wno-unused-parameter",
"-Wall",
"-Werror",
"-Wno-unused-parameter",
],

srcs: [
"core/AudioGlobal.cpp",
"core/AudioStream.cpp",
"core/AudioStreamBuilder.cpp",
"core/AAudioStreamParameters.cpp",
"legacy/AudioStreamLegacy.cpp",
"legacy/AudioStreamRecord.cpp",
"legacy/AudioStreamTrack.cpp",
"utility/AAudioUtilities.cpp",
"utility/FixedBlockAdapter.cpp",
"utility/FixedBlockReader.cpp",
"utility/FixedBlockWriter.cpp",
"fifo/FifoBuffer.cpp",
"fifo/FifoControllerBase.cpp",
"client/AAudioFlowGraph.cpp",
"client/AudioEndpoint.cpp",
"client/AudioStreamInternal.cpp",
"client/AudioStreamInternalCapture.cpp",
"client/AudioStreamInternalPlay.cpp",
"client/IsochronousClockModel.cpp",
"binding/AudioEndpointParcelable.cpp",
"binding/AAudioBinderAdapter.cpp",
"binding/AAudioBinderClient.cpp",
"binding/AAudioStreamRequest.cpp",
"binding/AAudioStreamConfiguration.cpp",
"binding/AAudioStreamRequest.cpp",
"binding/AudioEndpointParcelable.cpp",
"binding/RingBufferParcelable.cpp",
"binding/SharedMemoryParcelable.cpp",
"binding/SharedRegionParcelable.cpp",
"client/AAudioFlowGraph.cpp",
"client/AudioEndpoint.cpp",
"client/AudioStreamInternal.cpp",
"client/AudioStreamInternalCapture.cpp",
"client/AudioStreamInternalPlay.cpp",
"client/IsochronousClockModel.cpp",
"core/AAudioStreamParameters.cpp",
"core/AudioGlobal.cpp",
"core/AudioStream.cpp",
"core/AudioStreamBuilder.cpp",
"fifo/FifoBuffer.cpp",
"fifo/FifoControllerBase.cpp",
"flowgraph/ChannelCountConverter.cpp",
"flowgraph/ClipToRange.cpp",
"flowgraph/FlowGraphNode.cpp",
"flowgraph/Limiter.cpp",
"flowgraph/ManyToMultiConverter.cpp",
"flowgraph/MonoBlend.cpp",
"flowgraph/MonoToMultiConverter.cpp",
"flowgraph/MultiToMonoConverter.cpp",
"flowgraph/MultiToManyConverter.cpp",
"flowgraph/MultiToMonoConverter.cpp",
"flowgraph/RampLinear.cpp",
"flowgraph/SampleRateConverter.cpp",
"flowgraph/SinkFloat.cpp",
"flowgraph/SinkI8_24.cpp",
"flowgraph/SinkI16.cpp",
"flowgraph/SinkI24.cpp",
"flowgraph/SinkI32.cpp",
"flowgraph/SinkI8_24.cpp",
"flowgraph/SourceFloat.cpp",
"flowgraph/SourceI8_24.cpp",
"flowgraph/SourceI16.cpp",
"flowgraph/SourceI24.cpp",
"flowgraph/SourceI32.cpp",
"flowgraph/SourceI8_24.cpp",
"flowgraph/resampler/IntegerRatio.cpp",
"flowgraph/resampler/LinearResampler.cpp",
"flowgraph/resampler/MultiChannelResampler.cpp",
Expand All @@ -240,6 +235,13 @@ cc_library {
"flowgraph/resampler/PolyphaseResamplerStereo.cpp",
"flowgraph/resampler/SincResampler.cpp",
"flowgraph/resampler/SincResamplerStereo.cpp",
"legacy/AudioStreamLegacy.cpp",
"legacy/AudioStreamRecord.cpp",
"legacy/AudioStreamTrack.cpp",
"utility/AAudioUtilities.cpp",
"utility/FixedBlockAdapter.cpp",
"utility/FixedBlockReader.cpp",
"utility/FixedBlockWriter.cpp",
],
sanitize: {
integer_overflow: true,
Expand All @@ -263,17 +265,17 @@ aidl_interface {
],
srcs: [
"binding/aidl/aaudio/Endpoint.aidl",
"binding/aidl/aaudio/IAAudioClient.aidl",
"binding/aidl/aaudio/IAAudioService.aidl",
"binding/aidl/aaudio/RingBuffer.aidl",
"binding/aidl/aaudio/SharedRegion.aidl",
"binding/aidl/aaudio/StreamParameters.aidl",
"binding/aidl/aaudio/StreamRequest.aidl",
"binding/aidl/aaudio/IAAudioClient.aidl",
"binding/aidl/aaudio/IAAudioService.aidl",
],
imports: [
"audioclient-types-aidl",
"shared-file-region-aidl",
"framework-permission-aidl",
"shared-file-region-aidl",
],
backend: {
java: {
Expand Down
2 changes: 1 addition & 1 deletion media/libaaudio/tests/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ cc_binary {
srcs: ["test_steal_exclusive.cpp"],
shared_libs: [
"libaaudio",
"liblog",
"libbinder",
"libcutils",
"liblog",
"libutils",
],
}
Expand Down
Loading

0 comments on commit a159e4b

Please sign in to comment.