Fixes space for p4lang/p4rt-asciidoc #536
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dscano <[email protected]>
| @@ -13,7 +13,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - name: Build spec | |||
| run: | | |||
| docker run -v `pwd`/docs/v1:/usr/src/p4-spec p4lang/p4rt-asciidoc :latest make | |||
| docker run -v `pwd`/docs/v1:/usr/src/p4-spec p4lang/p4rt-asciidoc:latest make | |||
There was a problem hiding this comment.
@Dscano I believe you need to build the dockerfile before you docker run ... in all the CI scripts, or it'll fail to find the image. This is similar to what you had to do in the original MR:
p4runtime/.github/workflows/spec.yml
Line 28 in 7e981d8
It's a consequence of not having a public docker image. Unfortunately, this is not exposed until CI runs after the merge occurs. Can you make sure this is added to all the CI files accordingly? Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.