Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes space for p4lang/p4rt-asciidoc #535

Closed
wants to merge 0 commits into from
Closed

Conversation

Dscano
Copy link
Contributor

@Dscano Dscano commented Jan 21, 2025

Fixes space for p4lang/p4rt-asciidoc

@chrispsommers
Copy link
Collaborator

Hi @Dscano thanks for the fix. I think this MR needs some adjustments though. Have you synced to the latest upstream main? I would expect the MR message to not include all the older commits you made, only the three new changes. Also, the MR "description" should read something like "Fixes ." Could you make these changes? Thanks!

@Dscano Dscano changed the title fix space for p4lang/p4rt-asciidoc Fixes Jan 21, 2025
@Dscano Dscano changed the title Fixes Fixes space for p4lang/p4rt-asciidoc Jan 21, 2025
@Dscano Dscano force-pushed the main branch 2 times, most recently from 8c236e7 to 07f56e7 Compare January 21, 2025 21:29
@Dscano Dscano closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants