Networking: multiple relays, dial known nodes, allow&block-list #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreae
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 92.30% 92.21% -0.10%
==========================================
Files 102 102
Lines 16070 16100 +30
==========================================
+ Hits 14834 14847 +13
- Misses 1236 1253 +17
☔ View full report in Codecov by Sentry. |
sandreae
changed the title
sandreae
changed the title
This was
linked to
issues
Aug 25, 2023
4 tasks
adzialocha
reviewed
Aug 25, 2023
| @@ -116,7 +124,7 @@ impl P2pandaBehaviour { | |||
|
|
|||
| // Create a rendezvous client behaviour with default configuration if a rendezvous server | |||
| // address has been provided | |||
| let rendezvous_client = if network_config.relay_address.is_some() { | |||
| let rendezvous_client = if !network_config.relay_addresses.is_empty() { | |||
There was a problem hiding this comment.
I want to rename this field to relay_nodes, but let's do this later
adzialocha
approved these changes
Aug 25, 2023
sandreae
force-pushed
the
networking-final-round
branch
from
e040a33 to
59ba41c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Checklist
Add tests that cover your changesCHANGELOG.md