Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration of e/g CompositeID #104

Closed
wants to merge 44 commits into from
Closed

Integration of e/g CompositeID #104

wants to merge 44 commits into from

Conversation

cerminar
Copy link

PR description:

Integrate the new CompositeID for building TkElectrons.
The main changes are:

  • add the CompositeID BDT model to the e/g algo emulator
  • modify the TkObj, EmCaloObj and HadCaloObj dataformats to include the variables needed by the new model
  • change the CTL1 event data format and the packing/unpacking emulators accordingly (bump the CTL1 Event version)

Peter Eduard Meiring and others added 30 commits October 10, 2022 23:20
@cerminar
starting point composite ID emulator
6d56501
@cerminar
cast floats to apfixed, run inference and compare output
1664f0e
@cerminar
add scheleton to plug in CompositeID
c959fb5
@cerminar
incorporate compositeID as alternative to tkElectron, using skeleton …
808b13e 
…of previous commit
@cerminar
fix DR and add some verbosity
2f52af5
@cerminar
equip to write decoded tracks to the event
19f2526
@cerminar
add calo coordinates to PFCandidates
201cb52
@cerminar
trying to move normalizations to different function
fd68c4b
@cerminar
implement two BDT WPs
ea1f03a
@cerminar
fixes
0120200
@cerminar
Mapping of scores and WPs for consistent comparisons
8445954
@cerminar
trivialize the CompositeCandidate interface
df466e8
@cerminar
remove the cut on the CompositeID BDT and store the score in the TkEl…
de2a730 
…ectron object + some cosmetics
@cerminar
Remove pt10 cut from composite candidates
3dfe89f
@cerminar
remove duplicated files
839921f
@cerminar
remove duplicated files
9c38bb7
@cerminar
fix typo
2695a0e
@cerminar
add missing headers
c938910
@cerminar
first implementation of the new data-formats for CompositeID input fe…
9ebd3ef 
…atures
temporary changes to run emulator from firmware testbench
a873d19
fix conflict
44966d9
@cerminar
Merge pull request #10 from Pmeiring/compositeID_emulator_reorg
d22df66 
Changes for running testbench
@cerminar
reorder the code for adding the cluster-shape variables used by the c…
ff004f2 
…omposite ID to the HGC clusters
@cerminar
Merge branch 'compositeID_emulator_reorg' of https://github.com/cermi…
3819a93 
…nar/cmssw into compositeID_emulator_reorg
make # of composite candidates per cluster configurabel
21c13f2
@cerminar
add parameter for # of composite candidates per cluster
1a49435
change to new model with max tree depth of 4
795dd71
@cerminar
Merge pull request #11 from Pmeiring/compositeID_emulator_reorg_newmodel
0435970 
New model with max tree depth of 4
Replace egamma BDT with model using no input scaling
b420b2a
Update egamma BDT to model trained on hw values. Use inversion fn fro…
b0d2467 
…m jets
@cerminar cerminar marked this pull request as draft November 25, 2022 13:50
@gpetruc gpetruc added the to be ported to 12_5_X PR on old 12_3_X branch, in need of a rebase label Jan 12, 2023
@cerminar cerminar mentioned this pull request Jan 27, 2023
Merged
@gpetruc gpetruc removed the to be ported to 12_5_X PR on old 12_3_X branch, in need of a rebase label Mar 13, 2023
@gpetruc
Copy link
Collaborator

gpetruc commented Mar 13, 2023

replaced by #110

@gpetruc gpetruc closed this Mar 13, 2023
@cerminar cerminar mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cerminar @gpetruc