Resolve -tts edge overwriting file with empty data after written #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #56
A hacky refactoring to facilitate batch processing of an entire directory (and subdirectories) that contain epubs. Essentially, if the "input_file" is a directory, the script will recursively search for .epub files (file extension is currently case sensitive), then iterate over all epubs found and process them using the other parameters provided by the user.
…older for input file already exists
Bryksin
requested changes
Aug 24, 2024
| @@ -108,7 +108,6 @@ async def save( | |||
| frame_rate=24000, | |||
| channels=1 | |||
| ) | |||
| audio.export(audio_fname) | |||
There was a problem hiding this comment.
Maybe that is useful fix, though not fully sure, need testing
| input_folder_root = str(Path(config.input_file)) | ||
| output_folder_base = config.output_folder | ||
|
|
||
| for epub_file in epub_list: |
There was a problem hiding this comment.
No, sorry.
Maybe you would love to have a folder with a bunch of epubs and want to convert them all in one go, but no. please 1 book at a time, especially if you use OpenAI and each book costs money
|
Thanks for fixing. I already fixed the related issue in #71 by simplifying the related logic. Closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #56