OZ-558: Config points page auto-generation from EIP projects application.properties URLs. #22
Conversation
VaishSiddharth
changed the title
…d from github application.properties
VaishSiddharth
force-pushed
the
oz-558
branch
from
b8b69b0 to
c99280d
Compare
mks-d
changed the title
gen_pages.py
Outdated
| ODOO_OPENMRS_GITHUB_URL = "https://raw.githubusercontent.com/ozone-his/eip-odoo-openmrs/7773cdb2783c2b7a5310e49ec79e979a65f2c1e0/odoo-openmrs/src/main/resources/config/application.properties" | ||
| OPENMRS_ORTHANC_GITHUB_URL = "https://raw.githubusercontent.com/ozone-his/eip-openmrs-orthanc/45b2c6361da5afcb0bf281229f484e8bec7ae0f2/openmrs-orthanc/src/main/resources/config/application.properties" | ||
| KEYCLOCK_SUPERSET_GITHUB_URL = "" | ||
| OPENMRS_SENAITE_GITHUB_URL = "https://raw.githubusercontent.com/ozone-his/eip-openmrs-senaite/7184244ee52db4df85efab9fed9c63a2d993cbe1/senaite-openmrs/src/main/resources/config/application.properties" | ||
| ERPNEXT_OPENMRS_GITHUB_URL = "https://raw.githubusercontent.com/ozone-his/eip-erpnext-openmrs/789020a15dbbb10f0bd5b2c994a1de2e82cf7ae7/erpnext-openmrs/src/main/resources/config/application.properties" |
There was a problem hiding this comment.
Taking the example of eip-openmrs-senaite, why don't you use release tags like
https://raw.githubusercontent.com/ozone-his/eip-openmrs-senaite/refs/tags/2.1.0/senaite-openmrs/src/main/resources/config/application.properties
rather than what I suspect is the latest commit or so:
https://raw.githubusercontent.com/ozone-his/eip-openmrs-senaite/7184244ee52db4df85efab9fed9c63a2d993cbe1/senaite-openmrs/src/main/resources/config/application.properties
?
IMO the docs should be generated for a specific release or (alternatively, but probably not) for the bleeding edge:
https://raw.githubusercontent.com/ozone-his/eip-openmrs-senaite/refs/heads/main/senaite-openmrs/src/main/resources/config/application.properties
There was a problem hiding this comment.
Yeah makes sense. The problem is we will have to wait till the next release.
| app_github_dict = {'Odoo-OpenMRS Flows': ODOO_OPENMRS_GITHUB_URL, 'OpenMRS-SENAITE Flows': OPENMRS_SENAITE_GITHUB_URL, | ||
| 'ERPNext-OpenMRS Flows': ERPNEXT_OPENMRS_GITHUB_URL,'OpenMRS-Orthanc Flows': OPENMRS_ORTHANC_GITHUB_URL} |
There was a problem hiding this comment.
Does this kind of stuff not defeat the purpose a bit? I mean both the naming of each variable (eg. ODOO_OPENMRS_GITHUB_URL) and the writing of the string ahead of it (eg. 'Odoo-OpenMRS Flows').
I think we would like to end up in a situation where we provide a list of eip-a-b URLs and the script does all the magic.
There was a problem hiding this comment.
Yeah we can define this in the application.properties for each eip route but I think adding a new application to Ozone is not very frequent so we can have it hard coded here.
mks-d
changed the title
VaishSiddharth
changed the title
|
I think its ready now. Do note that I have added |
JIRA: https://mekomsolutions.atlassian.net/browse/OZ-558