Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parseHunkPositions to parse second part as hunk length instead of hunk end line #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix parseHunkPositions to parse second part as hunk length instead of hunk end line #17

wants to merge 4 commits into from

Conversation

andrew-myer
Copy link

@andrew-myer andrew-myer commented Mar 14, 2024 •
edited
Loading

Fix parsing hunk position to parse as length instead of hunk end line

Closes #18

@andrew-myer andrew-myer marked this pull request as ready for review March 14, 2024 21:00
@andrew-myer andrew-myer closed this Apr 1, 2024
@andrew-myer andrew-myer reopened this Apr 3, 2024
@andrew-myer andrew-myer mentioned this pull request Apr 10, 2024
Open
@andrew-myer andrew-myer changed the title Fix isLineInHunk to use hi.hunkEnd as length of hunk fix parseHunkPositions to parse second part as length instead of hunk end line Apr 10, 2024
@andrew-myer andrew-myer changed the title fix parseHunkPositions to parse second part as length instead of hunk end line fix parseHunkPositions to parse second part as hunk length instead of hunk end line Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly checking if line is in hunk when creating line comments
1 participant
@andrew-myer