Fixing few issues #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n variable on deactivate. Also added furst_run guard in method elapsed_changed.
|
Thanks Paul May I know your version of Rhythmbox and OS please? |
|
rhythmbox 2.97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Your plugin is what i looking for, but it won't work on my machine. So I made few changes. Without my changes after re-open rhythmbox playing started from beggining of track.
I've added first_run guard to elapsed_changed - on my machine after running rhythmbox this event occurs first.
Please, test my solution, and commit it if u want to.
Thanks,
Paul.
PS. its my first python code :)