Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci.savings-plan): fix banner notifications #14839

Open
wants to merge 2 commits into
base: feat/TAPC-2456-bump-ods18-SVP
Choose a base branch
from
Open

fix(pci.savings-plan): fix banner notifications #14839

wants to merge 2 commits into from

Conversation

Eric-ciccotti
Copy link
Contributor

@Eric-ciccotti Eric-ciccotti commented Jan 9, 2025 •
edited
Loading

Question Answer
Branch? feat/TAPC-2456-bump-ods18-SVP
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #TAPC-1861
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

This PR fix savings plan banner notifications issues

Related

@Eric-ciccotti Eric-ciccotti requested review from a team as code owners January 9, 2025 08:32
@Eric-ciccotti Eric-ciccotti requested review from chipp972, darsene, kqesar, frenautvh, qpavy and JacquesLarique and removed request for a team January 9, 2025 08:32
@github-actions github-actions bot added dependencies Pull requests that update a dependency file feature New feature has conflicts Has conflicts to resolve before merging labels Jan 9, 2025
@Eric-ciccotti Eric-ciccotti force-pushed the feat/TAPC-1861-banner-management branch from 288d57b to 093c7d3 Compare January 9, 2025 08:41
@Eric-ciccotti Eric-ciccotti changed the base branch from feat/TAPC-2456-bump-ods18-SVP to develop January 9, 2025 09:13
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 9, 2025
fix: set quantity to 1 if exceed
4353f80 
ref: TAPC-2456

Signed-off-by: Lionel Bueno <[email protected]>
@Eric-ciccotti Eric-ciccotti changed the base branch from develop to feat/TAPC-2456-bump-ods18-SVP January 9, 2025 14:52
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 9, 2025
@Eric-ciccotti Eric-ciccotti force-pushed the feat/TAPC-1861-banner-management branch from 093c7d3 to 35e0bf9 Compare January 9, 2025 15:01
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file has conflicts Has conflicts to resolve before merging labels Jan 9, 2025
@Eric-ciccotti Eric-ciccotti force-pushed the feat/TAPC-1861-banner-management branch from 35e0bf9 to c63cdaf Compare January 9, 2025 15:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lionel95200x
lionel95200x reviewed Jan 9, 2025
View reviewed changes
packages/manager/apps/pci-savings-plan/src/pages/listing/renew-modal/index.tsx

const { mutate: changePeriod } = useSavingsPlanChangePeriod(
savingsPlanId,
async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move it to a declared method

const onSucces = () => ...

useSavingsPlanChangePeriod(savingsPlanId, onSucces)

@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from 4353f80 to 667d9a4 Compare January 9, 2025 15:55
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 9, 2025
@lionel95200x lionel95200x force-pushed the feat/TAPC-2456-bump-ods18-SVP branch from 667d9a4 to f41ea6f Compare January 10, 2025 08:33
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel95200x lionel95200x lionel95200x left review comments

@chipp972 chipp972 Awaiting requested review from chipp972 chipp972 is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eric-ciccotti @lionel95200x