feat: upgrade to ruby 3.3 closes #33 #34
Conversation
|
@ghassanmas Hi, the upstream PR has been merged. What's the status of this PR? |
|
@DawoudSheraz if we merge it as it is, but then we need to use open-release/redwood.master as opposite to the default open-release/redwood.1 (redwood.1 doesn't have ruby update), or we wait for redwood.2. |
If we think this update to be important, we can draft v18.1.0. We don't need to wait for redwood.2. |
tutorforum/plugin.py
Outdated
| @@ -23,7 +23,8 @@ | |||
| "PORT": "4567", | |||
| "API_KEY": "forumapikey", | |||
| "REPOSITORY": "https://github.com/openedx/cs_comments_service.git", | |||
| "REPOSITORY_VERSION": "{{ OPENEDX_COMMON_VERSION }}", | |||
| # TEMP: after redwood.2 release replace with {{ OPENEDX_COMMON_VERSION }} | |||
| "REPOSITORY_VERSION": "open-release/redwood.master", | |||
| }, | |||
| } | |||
There was a problem hiding this comment.
@DawoudSheraz I have changed the default for FORUM_REPOSITORY_VERSION to open-release/redwood.master. if you okay with that it's ready to be reviewed/mrged, I have test it with tutor 18 already
There was a problem hiding this comment.
Hi, you dont need to change this value. This will be filled automatically based on tutor version (master or nightly).
There was a problem hiding this comment.
I meant to change so if make new release upon merge, consumers will be able to utilzie the new update, otherwise we wait for redwood.2... in case it's important, otherwise I would say let's wait for redwood.2
There was a problem hiding this comment.
Oh, I get it. Since upstream change is important for this PR, we can wait for redwood.2.
There was a problem hiding this comment.
@ghassanmas redwood.2 tagged tutor release overhangio/tutor#1110 is out, this PR should be good to go now.
There was a problem hiding this comment.
@ghassanmas Hi, catching up on ☝🏽
There was a problem hiding this comment.
Sorry I was on holiday most of the past week, I will take a look into this and #43 and then create a draft a reelase PR, today...
ghassanmas
force-pushed
the
ruby-upgrade
branch
from
047fe6a to
6634df7
Compare
Work on progress, changes here will depends on upstream PR:
- openedx/cs_comments_service#429Since it was merged after redwood, to be updated before redwood 2 or v18.0.1