fix: migrate to native filters on default course overview dashboard from filter box charts #53
+3
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom filter box charts
Danyal-Faheem
force-pushed
the
danyal/migrate-to-native-filters
branch
from
1940240 to
ef4e103
Compare
| @@ -5,8 +5,8 @@ | |||
| "css": "", | |||
| "dashboard_title": "Course overview", | |||
| "description": null, | |||
| "json_metadata": "{\"timed_refresh_immune_slices\": [], \"filter_scopes\": {\"2\": {\"video_id\": {\"scope\": [\"ROOT_ID\"], \"immune\": [17, 111, 5, 6, 8, 110, 10, 9, 113, 112, 114]}}, \"17\": {\"course_id\": {\"scope\": [\"ROOT_ID\"], \"immune\": []}, \"__time_range\": {\"scope\": [\"ROOT_ID\"], \"immune\": [111, 110, 10, 9, 113, 112]}}}, \"expanded_slices\": {}, \"refresh_frequency\": 0, \"default_filters\": \"{\\\"2\\\": {\\\"video_id\\\": \\\"7e9b434e6de3435ab99bd3fb25bde807\\\"}, \\\"17\\\": {\\\"course_id\\\": [\\\"course-v1:edX+DemoX+Demo_Course\\\"], \\\"__time_range\\\": \\\"Last month\\\"}}\", \"color_scheme\": null, \"show_native_filters\": true, \"native_filter_configuration\": [], \"remote_id\": 2}", | |||
| "position_json": "{\"CHART-7tiQ9gDD9Q\":{\"children\":[],\"id\":\"CHART-7tiQ9gDD9Q\",\"meta\":{\"chartId\":4,\"height\":47,\"sliceName\":\"Video X-Ray\",\"uuid\":\"34e9ed3f-c83a-46d2-8e24-e05170104376\",\"width\":12},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-FJE2P5KfpA\"],\"type\":\"CHART\"},\"CHART-JP2ofFRp0O\":{\"children\":[],\"id\":\"CHART-JP2ofFRp0O\",\"meta\":{\"chartId\":2,\"height\":23,\"sliceName\":\"Select video ID\",\"uuid\":\"270b8fd9-561b-4b9c-8e4e-9688b43ef283\",\"width\":4},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-xwP_iqbDk\"],\"type\":\"CHART\"},\"CHART-PGXKExBtbG\":{\"children\":[],\"id\":\"CHART-PGXKExBtbG\",\"meta\":{\"chartId\":9,\"height\":50,\"sliceName\":\"Enrolled learners level of education\",\"uuid\":\"7ecc94c7-576e-48ca-bbd8-0e2831117b35\",\"width\":4},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-0hFN_y-NgF\"],\"type\":\"CHART\"},\"CHART-PkrfaIrMNP\":{\"children\":[],\"id\":\"CHART-PkrfaIrMNP\",\"meta\":{\"chartId\":112,\"height\":51,\"sliceName\":\"Course grades\",\"uuid\":\"e979dfe0-a017-443f-9c40-453da4ff6839\",\"width\":6},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-1VpL9_y3C\"],\"type\":\"CHART\"},\"CHART-RIMipwKzGj\":{\"children\":[],\"id\":\"CHART-RIMipwKzGj\",\"meta\":{\"chartId\":110,\"height\":79,\"sliceName\":\"Course completion\",\"uuid\":\"c411f818-a0cf-4569-976b-33d16617603c\",\"width\":10},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-Ifn6tvGvdj\"],\"type\":\"CHART\"},\"CHART-RUE08HAwEd\":{\"children\":[],\"id\":\"CHART-RUE08HAwEd\",\"meta\":{\"chartId\":113,\"height\":51,\"sliceName\":\"Enrollment history\",\"uuid\":\"1fe1f8e6-11c1-4d1e-b287-8a175a269ed2\",\"width\":6},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-1VpL9_y3C\"],\"type\":\"CHART\"},\"CHART-_XdNUl5YJ9\":{\"children\":[],\"id\":\"CHART-_XdNUl5YJ9\",\"meta\":{\"chartId\":17,\"height\":35,\"sliceName\":\"Select course ID and time range\",\"uuid\":\"80ca2797-395e-45cb-a14f-c6a98cf0d9d1\",\"width\":4},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-yPuXNZUCnv\"],\"type\":\"CHART\"},\"CHART-ksac8VVbnJ\":{\"children\":[],\"id\":\"CHART-ksac8VVbnJ\",\"meta\":{\"chartId\":13,\"height\":23,\"sliceName\":\"Total watch time\",\"uuid\":\"9688f829-fa3d-4b0d-a715-cb2beedffe2d\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-xwP_iqbDk\"],\"type\":\"CHART\"},\"CHART-npBiWH7kMl\":{\"children\":[],\"id\":\"CHART-npBiWH7kMl\",\"meta\":{\"chartId\":111,\"height\":35,\"sliceName\":\"Enrolled students\",\"uuid\":\"33b8bf43-e777-4942-85fc-d042ddd71459\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-yPuXNZUCnv\"],\"type\":\"CHART\"},\"CHART-oTa9DVjYEB\":{\"children\":[],\"id\":\"CHART-oTa9DVjYEB\",\"meta\":{\"chartId\":114,\"height\":35,\"sliceName\":\"Average time on platform\",\"sliceNameOverride\":\"Average time in course\",\"uuid\":\"6fa4ad3e-af69-4b3f-964d-44fcb72e6dc7\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-yPuXNZUCnv\"],\"type\":\"CHART\"},\"CHART-p4ta63zmN2\":{\"children\":[],\"id\":\"CHART-p4ta63zmN2\",\"meta\":{\"chartId\":6,\"height\":35,\"sliceName\":\"Watched a video\",\"uuid\":\"fdc5ce1f-412f-434f-8a7c-d4ef3d2ede7c\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-1KC1JBGpc\"],\"type\":\"CHART\"},\"CHART-pjjDL63lIM\":{\"children\":[],\"id\":\"CHART-pjjDL63lIM\",\"meta\":{\"chartId\":10,\"height\":50,\"sliceName\":\"Enrolled learners gender\",\"uuid\":\"74763712-0193-4c3b-84ef-1a34b2aa17d8\",\"width\":4},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-0hFN_y-NgF\"],\"type\":\"CHART\"},\"CHART-t7KLpPYQxw\":{\"children\":[],\"id\":\"CHART-t7KLpPYQxw\",\"meta\":{\"chartId\":8,\"height\":35,\"sliceName\":\"Tried a problem\",\"uuid\":\"dfd0088c-74dd-4dfb-a221-4c1633d17072\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-1KC1JBGpc\"],\"type\":\"CHART\"},\"CHART-v7UYbl-ap6\":{\"children\":[],\"id\":\"CHART-v7UYbl-ap6\",\"meta\":{\"chartId\":14,\"height\":23,\"sliceName\":\"Unique viewers\",\"uuid\":\"e2bc6e71-eefa-457b-b7d8-8bee1ae8bae9\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-xwP_iqbDk\"],\"type\":\"CHART\"},\"CHART-xXCRFE4mZa\":{\"children\":[],\"id\":\"CHART-xXCRFE4mZa\",\"meta\":{\"chartId\":5,\"height\":35,\"sliceName\":\"Active students\",\"uuid\":\"b46a1e93-2bf6-4330-b9b4-67ae57d45a4e\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-yPuXNZUCnv\"],\"type\":\"CHART\"},\"CHART-y-ZSuLjhv7\":{\"children\":[],\"id\":\"CHART-y-ZSuLjhv7\",\"meta\":{\"chartId\":16,\"height\":23,\"sliceName\":\"Average learner watch time\",\"uuid\":\"bfbf6b44-928c-4141-a9c8-ae99cc5a87c4\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-xwP_iqbDk\",\"COLUMN-gumZdo_-5R\"],\"type\":\"CHART\"},\"COLUMN-gumZdo_-5R\":{\"children\":[\"CHART-y-ZSuLjhv7\"],\"id\":\"COLUMN-gumZdo_-5R\",\"meta\":{\"background\":\"BACKGROUND_TRANSPARENT\",\"width\":2},\"parents\":[\"ROOT_ID\",\"GRID_ID\",\"ROW-xwP_iqbDk\"],\"type\":\"COLUMN\"},\"DASHBOARD_VERSION_KEY\":\"v2\",\"GRID_ID\":{\"children\":[\"ROW-yPuXNZUCnv\",\"ROW-1KC1JBGpc\",\"ROW-Ifn6tvGvdj\",\"ROW-0hFN_y-NgF\",\"ROW-1VpL9_y3C\",\"ROW-xwP_iqbDk\",\"ROW-FJE2P5KfpA\"],\"id\":\"GRID_ID\",\"parents\":[\"ROOT_ID\"],\"type\":\"GRID\"},\"HEADER_ID\":{\"id\":\"HEADER_ID\",\"meta\":{\"text\":\"Course overview\"},\"type\":\"HEADER\"},\"ROOT_ID\":{\"children\":[\"GRID_ID\"],\"id\":\"ROOT_ID\",\"type\":\"ROOT\"},\"ROW-0hFN_y-NgF\":{\"children\":[\"CHART-pjjDL63lIM\",\"CHART-PGXKExBtbG\"],\"id\":\"ROW-0hFN_y-NgF\",\"meta\":{\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"},\"ROW-1KC1JBGpc\":{\"children\":[\"CHART-p4ta63zmN2\",\"CHART-t7KLpPYQxw\"],\"id\":\"ROW-1KC1JBGpc\",\"meta\":{\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"},\"ROW-1VpL9_y3C\":{\"children\":[\"CHART-RUE08HAwEd\",\"CHART-PkrfaIrMNP\"],\"id\":\"ROW-1VpL9_y3C\",\"meta\":{\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"},\"ROW-FJE2P5KfpA\":{\"children\":[\"CHART-7tiQ9gDD9Q\"],\"id\":\"ROW-FJE2P5KfpA\",\"meta\":{\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"},\"ROW-Ifn6tvGvdj\":{\"children\":[\"CHART-RIMipwKzGj\"],\"id\":\"ROW-Ifn6tvGvdj\",\"meta\":{\"0\":\"ROOT_ID\",\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"},\"ROW-xwP_iqbDk\":{\"children\":[\"CHART-JP2ofFRp0O\",\"CHART-v7UYbl-ap6\",\"COLUMN-gumZdo_-5R\",\"CHART-ksac8VVbnJ\"],\"id\":\"ROW-xwP_iqbDk\",\"meta\":{\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"},\"ROW-yPuXNZUCnv\":{\"children\":[\"CHART-_XdNUl5YJ9\",\"CHART-npBiWH7kMl\",\"CHART-xXCRFE4mZa\",\"CHART-oTa9DVjYEB\"],\"id\":\"ROW-yPuXNZUCnv\",\"meta\":{\"0\":\"ROOT_ID\",\"background\":\"BACKGROUND_TRANSPARENT\"},\"parents\":[\"ROOT_ID\",\"GRID_ID\"],\"type\":\"ROW\"}}", | |||
| "json_metadata": "{\"timed_refresh_immune_slices\": [], \"expanded_slices\": {}, \"refresh_frequency\": 0, \"default_filters\": \"{}\", \"color_scheme\": \"\", \"show_native_filters\": true, \"native_filter_configuration\": [{\"id\": \"NATIVE_FILTER-gfdtLP0ii1\", \"controlValues\": {\"enableEmptyFilter\": false, \"defaultToFirstItem\": false, \"multiSelect\": true, \"searchAllOptions\": true, \"inverseSelection\": false}, \"name\": \"Course ID\", \"filterType\": \"filter_select\", \"targets\": [{\"datasetId\": 2, \"column\": {\"name\": \"course_id\"}}], \"defaultDataMask\": {\"extraFormData\": {}, \"filterState\": {}, \"ownState\": {}}, \"cascadeParentIds\": [], \"scope\": {\"rootPath\": [\"ROOT_ID\"], \"excluded\": [3, 13, 12, 10, 9, 11]}, \"type\": \"NATIVE_FILTER\", \"description\": \"\", \"chartsInScope\": [1, 2, 4, 5, 6, 7, 8, 14, 15, 16], \"tabsInScope\": []}, {\"id\": \"NATIVE_FILTER-S7q5I-ddz9\", \"controlValues\": {\"enableEmptyFilter\": false, \"defaultToFirstItem\": false, \"multiSelect\": true, \"searchAllOptions\": true, \"inverseSelection\": false}, \"name\": \"Video ID\", \"filterType\": \"filter_select\", \"targets\": [{\"datasetId\": 1, \"column\": {\"name\": \"video_id\"}}], \"defaultDataMask\": {\"extraFormData\": {}, \"filterState\": {}, \"ownState\": {}}, \"cascadeParentIds\": [\"NATIVE_FILTER-gfdtLP0ii1\"], \"scope\": {\"rootPath\": [\"ROOT_ID\"], \"excluded\": [13, 6, 14, 15, 16, 12, 8, 1, 4, 7, 5, 2]}, \"type\": \"NATIVE_FILTER\", \"description\": \"\", \"chartsInScope\": [3, 9, 10, 11], \"tabsInScope\": []}], \"remote_id\": 1, \"shared_label_colors\": {}, \"label_colors\": {}, \"chart_configuration\": {}}", | |||
There was a problem hiding this comment.
How was this generated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter box charts have been completely deprecated as of superset 4.0.0.
For this purpose, we move towards native filters now for the native course overview dashboard.
Screenshots depicting the change:
Before:
After: