Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from setup.py/setuptools to pyproject.toml/hatch #52

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

Danyal-Faheem
Copy link
Collaborator

Comment on lines +36 to +37
"pylint",
"black"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need pylint and black here? I don't see them in setup.py.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were added so that the command make test works as expected to run normal tests since it requires both pylint and black. Previously, one had to install these themselves when working with cairn codebase.

@DawoudSheraz
Copy link
Contributor

@Danyal-Faheem Let's merge this unless you need additional eyes on this. Thanks

@Danyal-Faheem Danyal-Faheem merged commit e1d3744 into release Feb 18, 2025
2 checks passed
@Danyal-Faheem Danyal-Faheem deleted the danyal/migrate-to-pyproject branch February 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants