Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js/builtins): add PullIntoDescriptor type definitions #16190

Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 6, 2025

What does this PR do?

Adds a type definition for PullIntoDescriptor and annotates consuming code.

How did you verify your code works?

Only type changes. No logic is affected.

Copy link
Contributor Author

DonIsaac commented Jan 6, 2025

@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from 65d4699 to 2e80ea0 Compare January 6, 2025 23:04
@DonIsaac DonIsaac marked this pull request as ready for review January 6, 2025 23:04
@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from 2e80ea0 to 8ead628 Compare January 7, 2025 00:34
@robobun
Copy link

robobun commented Jan 7, 2025

Updated 9:16 PM PT - Jan 13th, 2025

@DonIsaac, your commit ecc1efe has passed in #9568! 🎉


🧪   try this PR locally:

bunx bun-pr 16190

@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from 8ead628 to cb755dc Compare January 7, 2025 04:11
Base automatically changed from don/test/dequeue to main January 8, 2025 23:03
@DonIsaac DonIsaac force-pushed the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch from cb755dc to ecc1efe Compare January 14, 2025 04:32
@DonIsaac DonIsaac added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@DonIsaac DonIsaac added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 5b608f2 Jan 17, 2025
70 checks passed
@DonIsaac DonIsaac deleted the 01-06-chore_js_builtins_add_pullintodescriptor_type_definitions branch January 17, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants