refactor: consolidate allocators #16061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 7:16 PM PT - Jan 1st, 2025
❌ @DonIsaac, your commit aa02a42 has 1 failures in
🧪 try this PR locally: bunx bun-pr 16061 |
… don/refactor/allocators
dylan-conway
reviewed
Jan 6, 2025
| }, | ||
| 0 => { | ||
| // TODO: @branchHint(.cold) after Zig 0.14 upgrade | ||
| std.debug.panic("LinuxMemFdAllocator ref_count underflow", .{}); |
There was a problem hiding this comment.
let's throw this in a if (Environment.isDebug) {... } block. I'm not familiar with how/where this allocator is dereferenced, but we don't want to introduce a panic for something that could be a noop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves all memory allocators into
src/allocators. The following allocators are affected:NullableAllocatorMimallocArenaMaxHeapAllocatorLinuxMemFdAllocatormemory_allocator.zig(CAllocator,ZAllocator,HugeAllocator, etc)I also added an underflow check to
LinuxMemFdAllocatorin case a consumer callsderef()without first callingref()