Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run npm install in cd #92

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Run npm install in cd #92

merged 1 commit into from
Aug 15, 2024

Conversation

pkong-ds
Copy link
Collaborator

No description provided.

@pkong-ds pkong-ds requested a review from YayunHuang August 15, 2024 08:55
@YayunHuang
Copy link
Contributor

@pkong-ds Just curious, how did we deploy before if the CD didn't work

@pkong-ds
Copy link
Collaborator Author

pkong-ds commented Aug 15, 2024 •
edited
Loading

@YayunHuang I think npm ci will

  • run npm install if it found node_modules/ have missing packages according to package.json

Also I think this applies to every npm __ commands haha

@YayunHuang YayunHuang merged commit d26280b into oursky:main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YayunHuang YayunHuang YayunHuang approved these changes

Assignees

@YayunHuang YayunHuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkong-ds @YayunHuang