Fix overflown colors hidden #26
Conversation
pkong-ds
commented
May 27, 2024
pkong-ds
commented
- scrollable
- tooltip won't hide
| function handleColorPickersTooltip() { | ||
| tippy("[data-tippy-content]", { | ||
| placement: "bottom-end", | ||
| theme: "light-border", | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
May I know how the original tooltips works?
And if we are using bootstrap, did we explore the bootstrap tooltips instead of loading in tippy.js.
There was a problem hiding this comment.
how the original tooltips works?
IIUC, there were no tooltip. I added it for better UX
if we are using bootstrap
I haven't used that in my styling, so went for the first google result which demo & API LGTM
did we explore the bootstrap tooltips instead of loading in tippy.js
Agree with this, maybe should've checked bootstrap first. Do you think we should remove tippy?
There was a problem hiding this comment.
I haven't used that in my styling,
Sure? May be remove it. If we can't remove it, did you check which version of bootstrap we are using? Is it easy to upgrade?
I will prefer to use bootstrap tooltips if it fit the purpose.
There was a problem hiding this comment.
okok, lemme check check, I prefer removing bootstrap if nothing using it
prefer to use bootstrap tooltips
May I know why? Is it just because the project was using it?
There was a problem hiding this comment.
just checked, ListItem.astro is using. Will remove tippy & use bootstrap
There was a problem hiding this comment.
May I know why? Is it just because the project was using it?
Yes and we can't randomly add lib/way of doing things to make the project become legacy project.
