Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CDN files to package #125

Merged
merged 16 commits into from
Aug 30, 2024
Merged

Change CDN files to package #125

merged 16 commits into from
Aug 30, 2024

Conversation

YayunHuang
Copy link
Contributor

Blocked by

What's in this PR?

Ref: MUP-160

Problem

cannot use psd package because the module use .coffee script and need to compile first, need to investigate how to import it in astro

@YayunHuang YayunHuang requested a review from pkong-ds August 30, 2024 08:58
pkong-ds
pkong-ds approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@pkong-ds pkong-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/pages/model/upload.js Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no _ prefix also works? 🥳

src/pages/model/_upload.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nvm 😞

@pkong-ds pkong-ds merged commit 9622493 into oursky:main Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkong-ds pkong-ds pkong-ds approved these changes

Assignees

@pkong-ds pkong-ds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YayunHuang @pkong-ds