Mockup speed enhancement

[YayunHuang]

Ref: MUP-179

demo video: https://linear.app/oursky/issue/MUP-179/mockup-generation-speed-enhancement#comment-ad48fbd1

[YayunHuang]

@pkong-ds I'm still removing some scripts that are no longer used, but I think you can see if there are any big issues with this update first

[pkong-ds]

Thanks, seems many comments. Can huddle if any misunderstanding

[pkong-ds]

Can the API still be runPreviewWorker and runWorker as 2 function?

That way the logic is contained inside each function, and no need to if (preview) else (generate)

[pkong-ds]

Same logic - can we also refactor as functions like onPreviewError, onPreviewSuccess?

Even better - different files for different complex logic

I planned to separate this holy 1000-line file into multiple files yesterday, but realized

• need to move upload.js into src/pages first ; which means
• need to change all CDN into package :sadfrog:

[YayunHuang]

@pkong-ds yes, I think it's better if we can do this after changing all CDN into package, and event typescript

[pkong-ds]

As per offline discussion, let's do the refactoring while upload.js is moved

[YayunHuang]

@pkong-ds all updated

[pkong-ds]

Thanks for addressing all the comments 👍 I pushed 2 commits to fix some minor stuff.

But I observe a bug (or expected behavior?) when testing this branch locally - if I upload more than 5 files, some orientations are lost.

I can reproduce this very consistently. Can you help check check? 🙏

6 images uploaded, only 8 files output

Screen.Recording.2024-08-30.at.3.17.56.AM.mp4

[YayunHuang]

@pkong-ds Fixed! I found that's because we add event listener in runPreviewWorker and runWoker but didn't remove them so some worker have multiple event listener so some mockups were replaced with incorrect images, fix by add {once: true} in addEventListener

[pkong-ds]

@YayunHuang Thanks a lot for your work🙏 🙏 LGTM