Workaround firefox worker init fail by limiting firefox workers to 2 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
force-pushed
the
mup-178-firefox-preview-worker-initialization-fail-in-firefox-only
branch
from
d3e784f to
ad34ae1
Compare
|
@YayunHuang Sor~ this might conflict with your upcoming changes |
YayunHuang
suggested changes
Aug 28, 2024
public/scripts/upload.js
Outdated
Comment on lines
237
to
239
| this.maxWorkers = isUserAgentFirefox() | ||
| ? MAX_FIREFOX_WEB_WORKERS | ||
| : navigator.hardwareConcurrency; |
There was a problem hiding this comment.
should also set to MAX_FIREFOX_WEB_WORKERS if navigator.hardwareConcurrency not support
https://caniuse.com/hardwareconcurrency
|
@YayunHuang Updated, thanks! (CI pending) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref MUP-178
@YayunHuang I also experienced
firefox always fail, which can be resolved byquitting firefox -> open againEDIT: by
resolved, I meanseeing code changes have effects in localhostI really don't like what I do in this PR, but guess this workaround
Sidenote - maybe we should add some
Recommend to use on Chrome?