Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc preview UX #121

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

pkong-ds
Copy link
Collaborator

@pkong-ds pkong-ds commented Aug 27, 2024

  • set preview on first available success preview
  • fix reset preview on remove any file
    • only reset if remove target is active preview
  • fix background flicker on switch preview

@pkong-ds pkong-ds force-pushed the fix-focus-on-first-available-preview branch from cc4da57 to 8c27d76 Compare August 27, 2024 16:12
@YayunHuang YayunHuang self-assigned this Aug 28, 2024
@YayunHuang YayunHuang self-requested a review August 28, 2024 03:39
Copy link
Contributor

@YayunHuang YayunHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pkong-ds pkong-ds merged commit 68631fb into oursky:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants