Fix mockup preview doesnt work when batch uploading #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is to use a queue
YayunHuang
suggested changes
Aug 27, 2024
There was a problem hiding this comment.
Thanks @pkong-ds, I found a small bug when testing, please check check
public/scripts/upload.js
Outdated
Comment on lines
726
to
739
| // observe fileListViewModel: imageUploads[].length | ||
| // side effect: generate preview mockup | ||
| mobx.reaction( | ||
| () => viewModel.fileList.imageUploads.length, | ||
| (newLen) => { | ||
| if (viewModel.fileList.imageUploads.length !== newLen) { | ||
| console.error("unexpected mobx error, image upload length not matched"); | ||
| return; | ||
| } | ||
| const newImage = viewModel.fileList.imageUploads[newLen - 1]; | ||
| viewModel.generatePreviewMockup(newImage); | ||
| }, | ||
| ); | ||
|
|
There was a problem hiding this comment.
it will trigger generate preview for last image when removing uploaded images from, that's why I add viewModel.generatePreviewMockup(newImage); in add function, maybe add check if newImage.previewURL != null?
There was a problem hiding this comment.
Lemme check it with
if newLen > oldLen
maybe add check if newImage.previewURL != null?
I think this is workaround. This side effect should only be triggered by target observable.
There was a problem hiding this comment.
Updated, thanks yayun!
YayunHuang
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
This is a batch job uploading 21 files.
However, there is another problem - the performance. It took ard 7 mins to generate all 21 previews
Preview - Upload
Screen.Recording.2024-08-27.at.7.28.16.PM.mp4
Preview - Preview
Screen.Recording.2024-08-27.at.7.31.18.PM.mp4