Fix often forget zip python package #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
reviewed
Aug 26, 2024
pkong-ds
requested changes
Aug 26, 2024
Makefile
Outdated
Comment on lines
77
to
86
| mkdir -p mockup | ||
| cp -r mockup_package/mockup/* mockup/ | ||
| zip -r public/mockup.zip mockup | ||
| rm -rf mockup | ||
|
|
There was a problem hiding this comment.
Sorry, forgot to say - if we are creating&removing sth in a script, can we follow the convention of putting these into tmp/ folder? thanks
There was a problem hiding this comment.
@pkong-ds updated~
YayunHuang
force-pushed
the
164-fix-often-forgoot-zip-python-package
branch
from
be970cd to
df9dc33
Compare
YayunHuang
force-pushed
the
164-fix-often-forgoot-zip-python-package
branch
from
df9dc33 to
618b639
Compare
pkong-ds
requested changes
Aug 26, 2024
Makefile
Outdated
Comment on lines
79
to
86
| cd tmp && \ | ||
| if [ -d "mockup" ]; then \ | ||
| zip -r ../public/mockup mockup; \ | ||
| else \ | ||
| echo "Error: Directory 'mockup' does not exist."; \ | ||
| exit 1; \ | ||
| fi | ||
|
|
There was a problem hiding this comment.
Why need cd into tmp?
Suggested change
| cd tmp && \ | |
| if [ -d "mockup" ]; then \ | |
| zip -r ../public/mockup mockup; \ | |
| else \ | |
| echo "Error: Directory 'mockup' does not exist."; \ | |
| exit 1; \ | |
| fi | |
| if [ -d "tmp/mockup" ]; then \ | |
| zip -r public/mockup tmp/mockup; \ | |
| else \ | |
| echo "Error: Directory 'mockup' does not exist in directory 'tmp'."; \ | |
| exit 1; \ | |
| fi | |
There was a problem hiding this comment.
@pkong-ds if we use zip -r public/mockup tmp/mockup; the unzip file will be
tmp/
mockup/
There was a problem hiding this comment.
okay, let's keep it then
pkong-ds
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: MUP-164