Fix image didn't fill screen area issue #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
reviewed
Aug 21, 2024
| @@ -190,15 +190,16 @@ def create_mockup_image(self, device_path, device_mask_path_prefix, result_path) | |||
| tmp = self.target_points[0].copy() | |||
| self.target_points[0] = self.target_points[1] | |||
| self.target_points[1] = tmp | |||
| shifted_points = self.target_points + np.array([PADDING, PADDING]) | |||
There was a problem hiding this comment.
question: How does adding padding and shifting points not affect the pictures fitting the phone?
e.g. if imageA fits perfectly on a phone (say moto-e) before. after adding padding, does imageA still fits perfectly? If so, how?
Thanks~
There was a problem hiding this comment.
This shows why it become incorrect before this update:
in #79 we adjusted the position of the pasted image if is_mockup_image_at_front, but forgot to update the other cases
There was a problem hiding this comment.
Thanks yayun! This explanation looks amazing. Can you put it in mockuphone.com/docs? 🙇
There was a problem hiding this comment.
@pkong-ds add docs to explain why we add padding when generating mockup ~
YayunHuang
force-pushed
the
mup-153-fix-image-didnt-fill-screen-area
branch
from
08aa237 to
84dc916
Compare
pkong-ds
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: MUP-153
adjust mask position because we add padding for image in: #79
Screen.Recording.2024-08-21.at.11.02.40.AM.mov