Fix preview called when remove item

oursky · Aug 27, 2024 · 695da96 · 695da96
1 parent 8b48c6d
commit 695da96
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/public/scripts/upload.js b/public/scripts/upload.js
@@ -723,11 +723,15 @@ function main() {
     },
   );
 
-  // observe fileListViewModel: imageUploads[].length
+  // observe fileListViewModel: imageUploads[].length increase
   // side effect: generate preview mockup
   mobx.reaction(
     () => viewModel.fileList.imageUploads.length,
-    (newLen) => {
+    (newLen, oldLen) => {
+      // we only want to trigger preview when the length increase
+      if (newLen <= oldLen) {
+        return;
+      }
       if (viewModel.fileList.imageUploads.length !== newLen) {
         console.error("unexpected mobx error, image upload length not matched");
         return;