Move error checking & state update in generatePreviewWorker

oursky · Aug 27, 2024 · 5ea9b16 · 5ea9b16
1 parent 0b09312
commit 5ea9b16
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/public/scripts/upload.js b/public/scripts/upload.js
@@ -251,6 +251,13 @@ class RootViewModel {
   }
 
   async generatePreviewMockup(imageUpload) {
+    if (newImage.isErrorState) {
+      return;
+    }
+    window.viewModel.fileList.updateImageUploadStateByULID(
+      newImage.ulid,
+      ImageUploadState.GeneratingPreview,
+    );
     runPreviewWorker(await this.getPreviewWorker(), imageUpload);
   }
 
@@ -785,14 +792,6 @@ function main() {
         return;
       }
       const newImage = viewModel.fileList.imageUploads[newLen - 1];
-
-      if (newImage.isErrorState) {
-        return;
-      }
-      window.viewModel.fileList.updateImageUploadStateByULID(
-        newImage.ulid,
-        ImageUploadState.GeneratingPreview,
-      );
       viewModel.generatePreviewMockup(newImage);
     },
   );