GBICSGO-1198: fixes default http client

ottogroup · Apr 11, 2024 · f877577 · f877577
1 parent 8170c77
commit f877577
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/pkg/compliance/sink_project_only_for_backup_check.go b/pkg/compliance/sink_project_only_for_backup_check.go
@@ -3,6 +3,7 @@ package compliance
 import (
 	"context"
 	"fmt"
+	"github.com/ottogroup/penelope/pkg/config"
 	"github.com/ottogroup/penelope/pkg/http/impersonate"
 	"go.opencensus.io/trace"
 	gimpersonate "google.golang.org/api/impersonate"
@@ -39,7 +40,10 @@ func NewSinkProjectOnlyForBackupCheckFunc(tokenSourceProvider impersonate.Target
 
 		options := []option.ClientOption{
 			option.WithTokenSource(tokenSource),
-			option.WithHTTPClient(http.DefaultClient),
+		}
+
+		if config.UseDefaultHttpClient.GetBoolOrDefault(false) {
+			options = append(options, option.WithHTTPClient(http.DefaultClient))
 		}
 
 		service, err := serviceusage.NewService(ctx, options...)

diff --git a/pkg/compliance/sink_project_with_singler_writer_check.go b/pkg/compliance/sink_project_with_singler_writer_check.go
@@ -7,6 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"github.com/golang/glog"
+	"github.com/ottogroup/penelope/pkg/config"
 	"github.com/ottogroup/penelope/pkg/http/impersonate"
 	"go.opencensus.io/trace"
 	gimpersonate "google.golang.org/api/impersonate"
@@ -49,7 +50,10 @@ func NewSinkProjectWithSinglerWriterCheckFunc(tokenSourceProvider impersonate.Ta
 
 		options := []option.ClientOption{
 			option.WithTokenSource(tokenSource),
-			option.WithHTTPClient(http.DefaultClient),
+		}
+
+		if config.UseDefaultHttpClient.GetBoolOrDefault(false) {
+			options = append(options, option.WithHTTPClient(http.DefaultClient))
 		}
 
 		policiesClient, err := iam.NewPoliciesRESTClient(ctx, options...)