Apply suggestions from code review

Co-authored-by: Mahmoud Rahbar Azad <[email protected]>
ottogroup · Apr 24, 2024 · 5a42393 · 5a42393
1 parent b1f8360
commit 5a42393
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/pkg/processor/creating_processor_factory.go b/pkg/processor/creating_processor_factory.go
@@ -440,6 +440,7 @@ func prepareSink(ctxIn context.Context, cloudStorageClient gcs.CloudStorageClien
 		projectNumber := strings.ReplaceAll(project.Name, "projects/", "")
 		bucketPolicy := &iam.Policy{}
 		// Storage Transfer Service needs to write to and read from the sink bucket
+		// based on https://cloud.google.com/storage-transfer/docs/sink-cloud-storage#required_permissions
 		storageTransferGSABinding := "serviceAccount:" + fmt.Sprintf(sinkSTSAccountScheme, projectNumber)
 		bucketPolicy.Add(storageTransferGSABinding, "roles/storage.legacyBucketWriter")
 		bucketPolicy.Add(storageTransferGSABinding, "roles/storage.legacyBucketReader")