Automate (former) champion badges #11
Conversation
main.py
Outdated
| ) | ||
|
|
||
| # user_badges has no unique key on (user, badge) so we have to check manually :( | ||
| existing_former_champion_badge = await db.fetch( |
There was a problem hiding this comment.
var is named former_champion but it's checking against CHAMPION_BADGE_ID?
There was a problem hiding this comment.
nit: it's probably best to use INSERT INTO ... IF NOT EXISTS ... ELSE UPDATE or w/e to make it one query, if possible
There was a problem hiding this comment.
not possible due to the lack of unique constraint since that's how it decides if it "exists" or would conflict etc. - needs to be resolved on the table layer first
There was a problem hiding this comment.
var is named former_champion but it's checking against CHAMPION_BADGE_ID?
note to self: don't trust F2
| ) | ||
|
|
||
| current_rank_one_user_id = await redis.zrevrange(rank_key, 0, 0) | ||
| users_who_peaked_at_rank_one.append({"user_id": current_rank_one_user_id}) |
There was a problem hiding this comment.
is this fetched separately to guard against the case where the #1 is not yet inserted into user_profile_history? (iirc the job runs nightly?)
There was a problem hiding this comment.
yes, the API endpoint that the website uses to fetch peak rank does similar functionality (fetches peak from database and also current, takes whichever is lower)
| # this is updated in a cron so we need to also check current rank one | ||
| users_who_peaked_at_rank_one = list( | ||
| await db.fetchall( | ||
| "SELECT DISTINCT user_id FROM user_profile_history WHERE mode = %s AND `rank` = 1", |
There was a problem hiding this comment.
Could you check how many users are going to receive a badge that don't currently have it, from the switch from manual -> auto based on user_profile_history data?
There was a problem hiding this comment.
I think there's a bit to consider here re. cases where someone cheated their way to #1 then got banned/unbanned -- I think this system would grant them the "former champion" badge in that case?
There was a problem hiding this comment.
I think there's a bit to consider here re. cases where someone cheated their way to #1 then got banned/unbanned
if we're not wiping this table when wiping a user for an unban then that's an issue in it's own way - that would mean their peak rank on their profile would already appear as whatever they peaked while cheating 😳
One day I'd love for score submission to be split into components and be able to do this event-based, but this is still better than manual for now.
This will be a requirement for full-stack automation of the badge as I'd like to automate the Discord roles as well via the new Discord linking functionality.