-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Initial release] Align all donations to a single US$5/mo "Akatsuki+ Membership" #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyui
requested review from
tsunyoku,
infernalfire72 and
lenforiee
as code owners
October 28, 2024 03:08
cmyui
changed the title
Align all branding to US$5/mo premium
[Initial release] Align all branding to US$5/mo premium
Oct 28, 2024
cmyui
commented
Oct 28, 2024
web/templates/premium.html
Outdated
@@ -1,7 +1,7 @@ | |||
{{/* prettier-ignore-start */}} | |||
{{/*### | |||
Handler=/premium | |||
TitleBar=Support Akatsuki (Premium) | |||
TitleBar=Akatsuki Premium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open question on branding -- e.g. Akatsuki Premium (Membership)
vs. Akatsuki+ (Membership)
-- here: https://discord.com/channels/1071583333022191677/1071602687126294600/1300301110371815546
cmyui
changed the title
[Initial release] Align all branding to US$5/mo premium
[Initial release] Align all branding to US$5/mo premium, refactor to subscription-based payments
Oct 28, 2024
cmyui
changed the title
[Initial release] Align all branding to US$5/mo premium, refactor to subscription-based payments
[Initial release] Align all branding to US$5/mo premium, switch to monthly subscriptions
Oct 28, 2024
cmyui
changed the title
[Initial release] Align all branding to US$5/mo premium, switch to monthly subscriptions
[Initial release] Align all donations to a single US$5 subscription billed monthly
Oct 28, 2024
cmyui
commented
Oct 28, 2024
This reverts commit cad41e6.
cmyui
changed the title
[Initial release] Align all donations to a single US$5 subscription billed monthly
[Initial release] Align all donations to a single US$5/mo premium tier
Oct 28, 2024
cmyui
changed the title
[Initial release] Align all donations to a single US$5/mo premium tier
[Initial release] Align all donations to a single US$5/mo "Akatsuki+ Membership"
Oct 28, 2024
Tested pretty heavily locally & confident in it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redid branding (supporter/premium -> "Akatsuki+"), UIs (mainly the descriptions of the perks), and backend for calculating payments. This PR does not move towards a proper paypal implementation of a monthly-billed-subscription model yet, but am working on that here: #173.
This is also needed for the initial release: osuAkatsuki/payments-service#11.
There are some other considerations in mind, but nothing release blocking has come to mind -- most other aspects (e.g. internal tooling or code concerns) can be addressed post-rollout asynchronously.
Tested locally: