🌱 differentiate between refs and sha gitab #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashearin
requested review from
spencerschrock and
laurentsimon
and removed request for
a team
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3729 +/- ##
==========================================
- Coverage 74.97% 68.80% -6.17%
==========================================
Files 216 216
Lines 14963 14966 +3
==========================================
- Hits 11219 10298 -921
- Misses 3080 4053 +973
+ Partials 664 615 -49 |
Signed-off-by: Allen Shearin <[email protected]>
ashearin
force-pushed
the
gitlab-sha-vs-ref
branch
from
3ccb7c2 to
1a1079e
Compare
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Dec 12, 2023
Signed-off-by: Allen Shearin <[email protected]>
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Signed-off-by: Allen Shearin <[email protected]>
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
raghavkaul
reviewed
Dec 13, 2023
Signed-off-by: Allen Shearin <[email protected]>
ashearin
temporarily deployed
to
integration-test
GitHub Actions
Inactive
spencerschrock
approved these changes
Dec 18, 2023
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a check to
listCheckRunsForRefin the Gitlab Handler to differentiate between shas and branches/tags and makes appropriate changes to the gitlab api call based on that check.What is the current behavior?
listCheckRunsForRefin the GItlab Handler takes in arefstring, but assumes that the ref is a sha when making the gitlab api call. Gitlab API sometimes handles refs as a branch or tag name, while sha refers to a commit hash. If in the future we passed in a branch or tag tolistCheckRunsForRefthe API would fail since we would handle it as a sha.What is the new behavior (if this is a feature change)?**
Added a check to compare the passed in
refstring against a regex matching a SHA value. If there is a match we handle the ref as a SHA, otherwise we handle it as a ref (branch/tag)Which issue(s) this PR fixes
Fixes #3395
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)