-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 SAST: add Snyk probe #3689
Merged
Merged
🌱 SAST: add Snyk probe #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Snyk's GitHub action (https://github.com/snyk/actions) as a probe. Signed-off-by: David Korczynski <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3689 +/- ##
==========================================
- Coverage 76.09% 70.81% -5.28%
==========================================
Files 216 217 +1
Lines 14966 15061 +95
==========================================
- Hits 11388 10666 -722
- Misses 2892 3753 +861
+ Partials 686 642 -44 |
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
This pull request is stale because it has been open for 10 days with no activity |
Signed-off-by: DavidKorczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
checks/raw/testdata/.github/workflows/github-workflow-snyk.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
spencerschrock
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left one minor change.
Signed-off-by: David Korczynski <[email protected]>
/scdiff generate SAST |
/scdiff generate SAST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Snyk's GitHub action (https://github.com/snyk/actions) as a probe.
What kind of change does this PR introduce?
Adds a probe checking the presence of Snyk SAST GitHub action.
What is the current behavior?
Scorecard will not recognize Snyk scanning as a SAST action.
What is the new behavior (if this is a feature change)?**
Scorecard will recognize Snyk scanning as a SAST action.
Which issue(s) this PR fixes
Ref: #2318
Special notes for your reviewer
Does this PR introduce a user-facing change?
Yes, in that it will change scoring of projects that use Snyk and users may now see Snyk-related details in the output.
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)