Skip to content

Commit

Permalink
remove left-over cases of "totalReleases" values in findings
Browse files Browse the repository at this point in the history
Signed-off-by: Adam Korczynski <[email protected]>
  • Loading branch information
AdamKorcz committed Dec 12, 2023
1 parent a626c26 commit 6e49946
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions probes/releasesAreSigned/impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ func Run(raw *checker.RawResults) ([]finding.Finding, string, error) {
return nil, Probe, fmt.Errorf("create finding: %w", err)
}

Check warning on line 87 in probes/releasesAreSigned/impl.go

View check run for this annotation

Codecov / codecov/patch

probes/releasesAreSigned/impl.go#L86-L87

Added lines #L86 - L87 were not covered by tests
f.Values = map[string]int{
"totalReleases": len(releases),
release.TagName: int(ValueTypeRelease),
asset.Name: int(ValueTypeReleaseAsset),
}
Expand Down Expand Up @@ -115,7 +114,6 @@ func Run(raw *checker.RawResults) ([]finding.Finding, string, error) {
return nil, Probe, fmt.Errorf("create finding: %w", err)
}

Check warning on line 115 in probes/releasesAreSigned/impl.go

View check run for this annotation

Codecov / codecov/patch

probes/releasesAreSigned/impl.go#L114-L115

Added lines #L114 - L115 were not covered by tests
f.Values = map[string]int{
"totalReleases": len(releases),
release.TagName: int(ValueTypeRelease),
}
findings = append(findings, *f)
Expand Down
2 changes: 0 additions & 2 deletions probes/releasesHaveProvenance/impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ func Run(raw *checker.RawResults) ([]finding.Finding, string, error) {
return nil, Probe, fmt.Errorf("create finding: %w", err)
}

Check warning on line 84 in probes/releasesHaveProvenance/impl.go

View check run for this annotation

Codecov / codecov/patch

probes/releasesHaveProvenance/impl.go#L83-L84

Added lines #L83 - L84 were not covered by tests
f.Values = map[string]int{
"totalReleases": len(releases),
release.TagName: int(ValueTypeRelease),
asset.Name: int(ValueTypeReleaseAsset),
}
Expand Down Expand Up @@ -112,7 +111,6 @@ func Run(raw *checker.RawResults) ([]finding.Finding, string, error) {
return nil, Probe, fmt.Errorf("create finding: %w", err)
}

Check warning on line 112 in probes/releasesHaveProvenance/impl.go

View check run for this annotation

Codecov / codecov/patch

probes/releasesHaveProvenance/impl.go#L111-L112

Added lines #L111 - L112 were not covered by tests
f.Values = map[string]int{
"totalReleases": len(releases),
release.TagName: int(ValueTypeRelease),
}
findings = append(findings, *f)
Expand Down

0 comments on commit 6e49946

Please sign in to comment.