highlight current page #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work again, I left a comment on the other PR. I think once you fixed it on the other PR you could try to apply the same patch to this one 👌 |
elhmn
requested changes
May 12, 2022
| @@ -31,7 +31,18 @@ | |||
| <li class="page-item"><a href="{{@root.fullUrl}}&page={{.}}" class="page-link">{{ . }}</a></li> | |||
| {{/if}} | |||
| {{else}} | |||
| <li class="page-item"><a href="{{@root.fullUrl}}?page={{.}}" class="page-link">{{ . }}</a></li> | |||
| {{#if (portContains @root.fullUrl "3000") }} | |||
There was a problem hiding this comment.
This won't work in production, as the fullUrl will be something different and probably won't use a port
elhmn
requested changes
May 12, 2022
src/views/partials/pagination.hbs
Outdated
| @@ -17,17 +17,32 @@ | |||
| <li class="disabled page-item"><a class="page-link">...</a></li> | |||
| {{/if}} | |||
| {{#each (displayPagesNumber interval current pages)}} | |||
| {{#if (ifEqual . current 0)}} | |||
| {{#if (ifEqual . current 1 0)}} | |||
There was a problem hiding this comment.
Suggested change
| {{#if (ifEqual . current 1 0)}} | |
| {{#if (ifEqual . current 1)}} |
src/helpers/handlebars.ts
Outdated
| } | ||
|
|
||
| export const not = (a: string): boolean=> { | ||
| return (!(a)); |
There was a problem hiding this comment.
Suggested change
| return (!(a)); | |
| return !a; |
There was a problem hiding this comment.
Thanks @elhmn. i will make the changes right away!!!
src/helpers/handlebars.ts
Outdated
| } | ||
|
|
||
|
|
||
| export const portContains = (a: string, b:string): boolean => { |
There was a problem hiding this comment.
Suggested change
| export const portContains = (a: string, b:string): boolean => { | |
| export const portContains = (a: string, b: string): boolean => { |
Comment on lines
21
to
+34
| <li class="active page-item"><a class="page-link">{{ . }}</a></li> | ||
| {{else}} | ||
| {{#if @root.hasParams}} | ||
| {{#if (contains @root.fullUrl "page")}} | ||
| <li class="page-item"><a href="{{{constructUrl @root.fullUrl .}}}" class="page-link">{{ . }}</a></li> | ||
| {{#if (ifContains @root.fullUrl .)}} | ||
| <li class="page-item active"> <a href="{{{constructUrl @root.fullUrl .}}}" class="page-link">{{ . }}</a></li> | ||
| {{else}} | ||
| <li class="page-item"><a href="{{{constructUrl @root.fullUrl .}}}" class="page-link">{{ . }}</a></li> | ||
| {{/if}} | ||
| {{else}} | ||
| <li class="page-item"><a href="{{@root.fullUrl}}&page={{.}}" class="page-link">{{ . }}</a></li> | ||
| {{/if}} | ||
| {{else}} | ||
| <li class="page-item"><a href="{{@root.fullUrl}}?page={{.}}" class="page-link">{{ . }}</a></li> | ||
| {{#if (portContains @root.fullUrl "3000") }} |
There was a problem hiding this comment.
This seems a little complicated and very difficult to follow, is it possible to simplify this entire logic ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.