Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDD : Open Source Driven Development #22

Merged
merged 1 commit into from
May 13, 2024
Merged

OSDD : Open Source Driven Development #22

merged 1 commit into from
May 13, 2024

Conversation

FanJups
Copy link
Member

@FanJups FanJups commented Mar 31, 2024

No description provided.

RMPR
RMPR reviewed Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@RMPR RMPR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, can you squash the two last commits into one? It does not seem clear to me why they are separate. Also, a more generic comment, can you convert the images to optimized JPeG? This is to be more space efficient and avoid people from Cameroon cloning with limited internet to be stuck.

data/authors/fanjups.md Outdated Show resolved Hide resolved
@tericcabrel
Copy link
Contributor

Hello @FanJups 👋🏾
We fixed the CI error; please can you update your repository with the latest changes and update this pull request? 🙏🏾

@FanJups
Copy link
Member Author

FanJups commented Apr 6, 2024

Great work, can you squash the two last commits into one? It does not seem clear to me why they are separate. Also, a more generic comment, can you convert the images to optimized JPeG? This is to be more space efficient and avoid people from Cameroon cloning with limited internet to be stuck.

Sure, thanks for the tips

FanJups added a commit to FanJups/blog that referenced this pull request Apr 6, 2024
@FanJups
feat: add new article OSDD : Open Source Driven Development (osscamer…
36bd90b 
…oon#22)
@FanJups FanJups force-pushed the open-source-driven-development branch from 447b5ab to 36bd90b Compare April 6, 2024 20:21
@FanJups
Copy link
Member Author

FanJups commented Apr 6, 2024

These articles helped me to squash https://www.freecodecamp.org/news/git-squash-commits/ https://stackoverflow.com/questions/5667884/how-to-squash-commits-in-git-after-they-have-been-pushed

FanJups added a commit to FanJups/blog that referenced this pull request Apr 6, 2024
@FanJups
feat: add new article OSDD : Open Source Driven Development (osscamer…
59dae12 
…oon#22)
@FanJups FanJups force-pushed the open-source-driven-development branch from 36bd90b to 59dae12 Compare April 6, 2024 20:26
@FanJups
Copy link
Member Author

FanJups commented Apr 6, 2024

Hello @FanJups 👋🏾 We fixed the CI error; please can you update your repository with the latest changes and update this pull request? 🙏🏾

done

@FanJups
Copy link
Member Author

FanJups commented Apr 6, 2024

@RMPR @tericcabrel , please check again 💯

@FanJups FanJups requested a review from RMPR April 6, 2024 21:18
@FanJups
Copy link
Member Author

FanJups commented Apr 9, 2024 •
edited
Loading

@tericcabrel I got this CI error

#21 ERROR: denied: installation not allowed to Write organization package
------
 > pushing ghcr.io/osscameroon/blog:ec7382128144d1c30568651e6a7667662b814aa8 with docker:
------
ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

FanJups added a commit to FanJups/blog that referenced this pull request Apr 10, 2024
@FanJups @RMPR
feat: add new article OSDD : Open Source Driven Development (osscamer…
475dd3f 
…oon#22)

Co-authored-by: Paul Mairo <[email protected]>
@FanJups FanJups force-pushed the open-source-driven-development branch from c7555c1 to 475dd3f Compare April 10, 2024 00:11
@RMPR
Copy link
Collaborator

RMPR commented Apr 15, 2024

@tericcabrel I got this CI error

#21 ERROR: denied: installation not allowed to Write organization package
------
 > pushing ghcr.io/osscameroon/blog:ec7382128144d1c30568651e6a7667662b814aa8 with docker:
------
ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

This has been fixed #24
Can you rebase your branch on the latest master?

@FanJups
Copy link
Member Author

FanJups commented Apr 15, 2024

@tericcabrel I got this CI error

#21 ERROR: denied: installation not allowed to Write organization package
------
 > pushing ghcr.io/osscameroon/blog:ec7382128144d1c30568651e6a7667662b814aa8 with docker:
------
ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

This has been fixed #24 Can you rebase your branch on the latest master?

Looks like, its already done days ago
Screenshot_20240415_151330_Chrome

@FanJups
Copy link
Member Author

FanJups commented Apr 15, 2024

@tericcabrel I got this CI error

#21 ERROR: denied: installation not allowed to Write organization package
------
 > pushing ghcr.io/osscameroon/blog:ec7382128144d1c30568651e6a7667662b814aa8 with docker:
------
ERROR: denied: installation not allowed to Write organization package
Error: buildx failed with: ERROR: denied: installation not allowed to Write organization package

This has been fixed #24 Can you rebase your branch on the latest master?

Looks like, its already done days ago Screenshot_20240415_151330_Chrome

Screenshot_20240415_151911_Chrome

@FanJups
Copy link
Member Author

FanJups commented Apr 15, 2024 •
edited
Loading

I also tried again to rebase but everything is up to date

PS C:\GitHub\blog> git status
On branch open-source-driven-development
Your branch is up to date with 'origin/open-source-driven-development'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        package-lock.json

nothing added to commit but untracked files present (use "git add" to track)
PS C:\GitHub\blog> git rebase upstream/main
Current branch open-source-driven-development is up to date.
PS C:\GitHub\blog>

@tericcabrel
Copy link
Contributor

Hello @FanJups I'm investigating 👍🏾

FanJups added a commit to FanJups/blog that referenced this pull request Apr 23, 2024
@FanJups
feat: add new article OSDD : Open Source Driven Development (osscamer…
f042c9f 
…oon#22)

Co-authored-by: Paul Mairo <[email protected]>

feat: add Telegram Messenger organization
@FanJups FanJups force-pushed the open-source-driven-development branch from 684d639 to f042c9f Compare April 23, 2024 06:44
@FanJups
Copy link
Member Author

FanJups commented Apr 27, 2024

Ok thanks @tericcabrel , please any updates ?

@tericcabrel
Copy link
Contributor

After checking with @FanJups, it seems like there is a permission issue with the GitHub container registry when the PR comes from a fork. I'm still investigating!

@FanJups
feat: add new article OSDD : Open Source Driven Development (osscamer…
ec8638e 
…oon#22)

Co-authored-by: Paul Mairo <[email protected]>

feat: add Telegram Messenger organization
@FanJups FanJups force-pushed the open-source-driven-development branch from f042c9f to ec8638e Compare May 10, 2024 20:48
@FanJups
Copy link
Member Author

FanJups commented May 10, 2024

@tericcabrel , looks like everything is ok now after @elhmn 's commit

@tericcabrel tericcabrel requested a review from RMPR May 11, 2024 07:08
@FanJups
Copy link
Member Author

FanJups commented May 11, 2024

@tericcabrel , I can not invite you as a reviewer given that I am not admin on this repo

@FanJups
Copy link
Member Author

FanJups commented May 11, 2024

@elhmn just changed the number of reviewers from 2 to 1 then with @RMPR pending approval, we are all set.

@tericcabrel tericcabrel self-requested a review May 12, 2024 18:27
@RMPR RMPR merged commit baa1de4 into osscameroon:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMPR RMPR RMPR approved these changes

@tericcabrel tericcabrel tericcabrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FanJups @tericcabrel @RMPR