Add tidal_channel as a valid waterway where streams can end
#2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the wiki, the tidal_channel exists outside of the coastline. Hence, coastline_sinkhole will not contain the end point of a stream connected to such a channel. Fixing it this way looked easier than adding it to coastline_sinkhole. Also removes an unused (and probably wrongly defined) column. See osm-fr#2086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the wiki, the
tidal_channelexists outside of the coastline. Hence, tablecoastline_sinkholewill not contain the end point of a stream connected to such a channel.Fixing it this way looked easier than adding it to
coastline_sinkhole.Also removes an unused (and probably wrongly defined) column.
See #2086