Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for CandidatesView (20250128) #1568

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

WhiredPlanck
Copy link
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes # N/A

Feature

Describe features of this pull request

This PR is to fix and improve several issues found in the last PR (#1567):

  1. CandidatesView will not block keyboardView anymore.
  2. Touch events of CandidatesView is fully work anytime.
  3. CandidatesView can now automatically avoid obscuring the input box
  4. The preferences will take effect immediately once them changes.

And ...

Happy Chinese New Year!

(Because it is the holiday now, if no one reviews it by 23:30 tonight, I will merge this PR myself.)

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@WhiredPlanck WhiredPlanck requested a review from goofyz January 29, 2025 03:19
@WhiredPlanck WhiredPlanck merged commit cdaa77c into osfans:develop Jan 29, 2025
3 checks passed
@WhiredPlanck WhiredPlanck deleted the refactor-250128 branch January 29, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant