Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LieAlgebras: Collect and update rep theory stuff #4541

Merged
merged 11 commits into from
Feb 11, 2025
Merged

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Feb 5, 2025

Changes:

  • Collect functions for rep theory of semisimple Lie algebras in a single file (from LieAlgebraModule.jl and RootSystem.jl)
  • Merge the docstrings coming from two different files; simplify the delegation dispatches a bit
  • Add the docstrings to a markdown page
  • Restrict all functions to semisimple Lie algebras in char 0 (both in docstring and with @req)
  • Fix some nasty bugs in Oscar-to-GAP conversion for cases where an Oscar root system is known, and the Oscar Chevalley basis is different from basis(L). In this case we construct the GAP Lie algebra with basis(L) as gens. However, this does not imply (in GAP) that this list is stored neither in CanonicalBasis nor in Basis, on which we relied when translating the chevalley basis. Instead, we now use a relative basis based on GeneratorsOfAlgebra on the GAP side to get the basis we constructed the Lie algebra with for element translation, and use element translation to translate the Chevalley basis.

@lgoettgens lgoettgens added topic: LieTheory experimental Only changes experimental parts of the code labels Feb 5, 2025
that only happen if an Oscar root system is known, and the Chevalley basis is different from the basis
L = special_orthogonal_lie_algebra(cyclotomic_field(4)[1], 4)
V = simple_module(L, [1, 1, 0, 0])
V = simple_module(L, [1, 1])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: change this weight to something non-symmetric

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (069bd41) to head (e3fc1c5).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4541      +/-   ##
==========================================
+ Coverage   84.41%   84.44%   +0.03%     
==========================================
  Files         672      673       +1     
  Lines       89155    89190      +35     
==========================================
+ Hits        75256    75317      +61     
+ Misses      13899    13873      -26     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/AbstractLieAlgebra.jl 96.75% <100.00%> (+0.12%) ⬆️
experimental/LieAlgebras/src/LieAlgebra.jl 88.52% <100.00%> (+0.15%) ⬆️
experimental/LieAlgebras/src/LieAlgebraModule.jl 90.21% <ø> (+1.50%) ⬆️
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
experimental/LieAlgebras/src/SSLieAlgebraModule.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/iso_oscar_gap.jl 100.00% <100.00%> (+4.34%) ⬆️
experimental/LieAlgebras/src/serialization.jl 100.00% <ø> (ø)
experimental/LieAlgebras/test/LieAlgebra-test.jl 100.00% <ø> (ø)
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl 100.00% <ø> (ø)
...mental/LieAlgebras/test/SSLieAlgebraModule-test.jl 100.00% <100.00%> (ø)
... and 2 more

... and 5 files with indirect coverage changes

@lgoettgens lgoettgens marked this pull request as ready for review February 5, 2025 23:25
@lgoettgens lgoettgens requested a review from fingolfin February 5, 2025 23:25
@lgoettgens lgoettgens enabled auto-merge (squash) February 11, 2025 08:18
@lgoettgens lgoettgens merged commit 12ab2af into master Feb 11, 2025
25 of 29 checks passed
@lgoettgens lgoettgens deleted the lg/Lie-ss-reptheory branch February 11, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants