-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LieAlgebras: Collect and update rep theory stuff #4541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38b5ded
to
8e61ff2
Compare
that only happen if an Oscar root system is known, and the Chevalley basis is different from the basis
df4f099
to
97b8f0d
Compare
lgoettgens
commented
Feb 5, 2025
L = special_orthogonal_lie_algebra(cyclotomic_field(4)[1], 4) | ||
V = simple_module(L, [1, 1, 0, 0]) | ||
V = simple_module(L, [1, 1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: change this weight to something non-symmetric
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4541 +/- ##
==========================================
+ Coverage 84.41% 84.44% +0.03%
==========================================
Files 672 673 +1
Lines 89155 89190 +35
==========================================
+ Hits 75256 75317 +61
+ Misses 13899 13873 -26
|
fingolfin
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
LieAlgebraModule.jl
andRootSystem.jl
)@req
)basis(L)
. In this case we construct the GAP Lie algebra withbasis(L)
as gens. However, this does not imply (in GAP) that this list is stored neither inCanonicalBasis
nor inBasis
, on which we relied when translating the chevalley basis. Instead, we now use a relative basis based onGeneratorsOfAlgebra
on the GAP side to get the basis we constructed the Lie algebra with for element translation, and use element translation to translate the Chevalley basis.