Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add multiple parameters per rule support on component definition #1504

Merged
merged 12 commits into from
Feb 22, 2024

Conversation

AleJo2995
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1495

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

Signed-off-by: Alejandro Jose Leiva Palomo <[email protected]>
@AleJo2995
Copy link
Collaborator Author

AleJo2995 commented Feb 1, 2024

In Draft while I´m still finishing to add more test cases, but logic has been corrected to make tests pass accordingly and consistently

@AleJo2995 AleJo2995 marked this pull request as ready for review February 8, 2024 03:08
Copy link
Member

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995 AleJo2995 merged commit 96e3f02 into develop Feb 22, 2024
15 checks passed
@AleJo2995 AleJo2995 deleted the fix/multiple-params-per-rule branch February 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to have multiple parameters per rule
2 participants