fix: make sonar happy -> reduce complexity

Signed-off-by: Lou DeGenaro <[email protected]>
oscal-compass · Feb 6, 2024 · f9a1eee · f9a1eee
1 parent e987665
commit f9a1eee
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/trestle/core/catalog/catalog_interface.py b/trestle/core/catalog/catalog_interface.py
@@ -298,18 +298,20 @@ def get_statement_part_id_map(self, label_as_key: bool) -> Dict[str, Dict[str, s
         id_map = {}
         for control in self.get_all_controls_from_catalog(True):
             statement_part = get_item_from_list(control.parts, const.STATEMENT, lambda p: p.name)
-            if statement_part:
-                id_dict: Dict[str, str] = {}
-                for sub_part in as_list(statement_part.parts):
-                    label = ControlInterface.get_label(sub_part)
-                    # skip add to map for empty label
-                    if label:
-                        if label_as_key:
-                            id_dict[label] = sub_part.id
-                        else:
-                            id_dict[sub_part.id] = label
-                if id_dict:
-                    id_map[control.id] = id_dict
+            if not statement_part:
+                continue
+            id_dict: Dict[str, str] = {}
+            for sub_part in as_list(statement_part.parts):
+                label = ControlInterface.get_label(sub_part)
+                # skip add to map for empty label
+                if not label:
+                    continue
+                if label_as_key:
+                    id_dict[label] = sub_part.id
+                else:
+                    id_dict[sub_part.id] = label
+            if id_dict:
+                id_map[control.id] = id_dict
         return id_map
 
     @staticmethod