Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates workflow for v9 of semantic release #38

Closed
wants to merge 6 commits into from

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Apr 15, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Updates semantic release logic to match trestle

Fixes #37

Related to oscal-compass/compliance-trestle#1564 and will require the same pypi setup

Key links:

The latest version of semantic-release does not support setup.cfg.
Pinning to the same version as compliance-trestle so the upgrades
can be made in sync. This project is still in beta so adding an option
to force minor releases for breaking changes.

Signed-off-by: Jennifer Power <[email protected]>
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432
Copy link
Member Author

@vikas-agarwal76 Thanks for the review. I did a additional pre-merge review and realized that the MINOR variable was not being set in the release workflow. Added a7ff1ee so we can set the value from the repository variables.

@jpower432 jpower432 added this to the 0.3.0 milestone Apr 26, 2024
@jpower432
Copy link
Member Author

Currently working on debugging this CI failure. This issue may be related to https://bugs.python.org/issue44061 and the solution may be to pin to another version of python 3.8 and add an issue to compliance-trestle.

@jpower432 jpower432 marked this pull request as draft July 18, 2024 14:21
* docs: updates README and setup.cfg with new organization

Signed-off-by: Jennifer Power <[email protected]>

* docs: updates CODE OF CONDUCT to match compliance-trestle

Signed-off-by: Jennifer Power <[email protected]>

* docs: updates issue templates with new organization and repo information

Signed-off-by: Jennifer Power <[email protected]>

* ci: updates workflow files with correct organization information

Signed-off-by: Jennifer Power <[email protected]>

* docs: updates MAINTAINER.md

* docs: updates CONTRIBUTING.md with trestle guidance

Signed-off-by: Jennifer Power <[email protected]>

* docs: fixes grammatical errors in contributing doc

Signed-off-by: Jennifer Power <[email protected]>

---------

Signed-off-by: Jennifer Power <[email protected]>
* chore(deps): updates trestle to new major version

Signed-off-by: Jennifer Power <[email protected]>

* chore(deps): drops python 3.8 support, adds 3.10 and 3.11

Aligns supported python versions with compliance-trestle

Signed-off-by: Jennifer Power <[email protected]>

* chore: replaces pkg_resources with importlib.resources

pkg_resources is deprecated in Python 3.11

Signed-off-by: Jennifer Power <[email protected]>

---------

Signed-off-by: Jennifer Power <[email protected]>
Align semantic release update logic with trestle

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 changed the title fix: pins semantic release to version v7 and adds an optional minor flag fix: updates workflow for v9 of semantic release Jul 23, 2024
@jpower432
Copy link
Member Author

Closing in favor of #46

@jpower432 jpower432 closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The semantic release job is not updating the repository
2 participants