Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fedramp plugin release #31

Merged
merged 2 commits into from
Apr 10, 2024
Merged

chore: fedramp plugin release #31

merged 2 commits into from
Apr 10, 2024

Conversation

jpower432
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Merge fixes into main that will fix the release workflow

Key links:

* chore: removes windows dev tool install from python-push.yml

Signed-off-by: Jennifer Power <[email protected]>

* chore: removes direct-merge-action from python-push.yml

Signed-off-by: Jennifer Power <[email protected]>

* ci: removes sonar job and combines lint and test into build

This alter the CI Trestle Deploy workflow to match the
compliance-trestle workflow

Signed-off-by: Jennifer Power <[email protected]>

---------

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review March 7, 2024 18:23
@jpower432
Copy link
Member Author

Putting this back into draft until #33 is resolved and merged into develop

@jpower432 jpower432 marked this pull request as draft March 21, 2024 17:29
* docs: updates README and setup.cfg with new organization

Signed-off-by: Jennifer Power <[email protected]>

* docs: updates CODE OF CONDUCT to match compliance-trestle

Signed-off-by: Jennifer Power <[email protected]>

* docs: updates issue templates with new organization and repo information

Signed-off-by: Jennifer Power <[email protected]>

* ci: updates workflow files with correct organization information

Signed-off-by: Jennifer Power <[email protected]>

* docs: updates MAINTAINER.md

* docs: updates CONTRIBUTING.md with trestle guidance

Signed-off-by: Jennifer Power <[email protected]>

* docs: fixes grammatical errors in contributing doc

Signed-off-by: Jennifer Power <[email protected]>

---------

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review April 8, 2024 13:16
@jpower432
Copy link
Member Author

@vikas-agarwal76 I have marked this ready for review now that the fixes have been merged into develop for the organization move. PTAL.

Copy link
Member

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 0b78f39 into main Apr 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants