Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates content and git submodule for FedRAMP Rev5 validation #22

Merged
merged 2 commits into from
Feb 8, 2024
Merged

feat: updates content and git submodule for FedRAMP Rev5 validation #22

merged 2 commits into from
Feb 8, 2024

Conversation

jpower432
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Stacked with #21

Main changes:

  • Updates FedRAMP submodule and removes the NIST submodule
  • Add a script to download the oscal-converters from the OSCAL 1.0.6 release. They are now release artifacts and do not exist in the repo
  • Update the ssp.xsl with the latest rules
  • Updates FedRAMP content using the make fedramp-copy target to Rev5

Key links:

@jpower432
feat: updates content from FedRAMP Rev4 to Rev5
88bc191 
Updates FedRAMP submodule to the latest commit

The location of the XSLT has changed from the repository to the OSCAL
release so the NIST submodule was removed and the download_oscal_converters
script was added

BREAKING CHANGE: This drops support for Rev4 validation

Signed-off-by: Jennifer Power <[email protected]>

---------

Signed-off-by: Jennifer Power <[email protected]>
@jpower432
test: adds assertions to validate command unit tests
d6365fc 
Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 force-pushed the feat/rev4-to-rev5 branch 2 times, most recently from 1f9249e to d6365fc Compare February 7, 2024 22:07
@jpower432 jpower432 marked this pull request as ready for review February 7, 2024 22:13
@jpower432
Copy link
Member Author

Failing jobs are related to #23 and #25

vikas-agarwal76
vikas-agarwal76 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit d09c742 into oscal-compass:develop Feb 8, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @vikas-agarwal76